Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the core/template block to reusable blocks that only has a single block #10271

Closed
slimmilkduds opened this issue Oct 1, 2018 · 4 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@slimmilkduds
Copy link

slimmilkduds commented Oct 1, 2018

Is your feature request related to a problem? Please describe.
When you create a reusable block that consists of multiple reusable blocks you get the added enormous benefit of being able to add (or remove) blocks when you edit them. If you create a reusable block from a single block you are forever stuck with just a single block.

Describe the solution you'd like
I want to be able to add more blocks when I edit a reusable block that only consists of one block.

Describe alternatives you've considered
This would kind of be dealt with if it was possible to edit reusable blocks like regulat cpts but even if that becomes possible that would mean a bunch of extra steps to do this.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Testing Needs further testing to be confirmed. labels Oct 1, 2018
@mtias mtias removed the Needs Testing Needs further testing to be confirmed. label Oct 7, 2018
@slimmilkduds
Copy link
Author

Another approach could be to add a transform block option so you convert from a reusable block to a reusable template

@noisysocks noisysocks added the Needs Design Feedback Needs general design feedback. label Nov 5, 2018
@noisysocks noisysocks added this to the Future: Phase 2 milestone Nov 5, 2018
@noisysocks
Copy link
Member

Interesting idea. I guess my only fear is that it might complicate the basic use-case which is to take a single block and make it reusable.

This would kind of be dealt with if it was possible to edit reusable blocks like regulat cpts but even if that becomes possible that would mean a bunch of extra steps to do this.

This is possible as of Gutenberg 4.1, see #10751.

@slimmilkduds
Copy link
Author

slimmilkduds commented Nov 5, 2018

I agree that it might complicate the basic use case. An option to convert a reusable block to a reusable template however might get rid of that problem. Anyhow, as you note, 4.1 at least allows a work around for this.

@mapk
Copy link
Contributor

mapk commented Mar 8, 2019

It appears this is all possible now. I can edit a reusable block, add other blocks, and save it again. Closing this issue.

@mapk mapk closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants