Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Status of Columns for Release #10560

Closed
mrwweb opened this issue Oct 12, 2018 · 9 comments
Closed

Clarify Status of Columns for Release #10560

mrwweb opened this issue Oct 12, 2018 · 9 comments
Labels
[Block] Columns Affects the Columns Block [Type] Question Questions about the design or development of the editor.
Milestone

Comments

@mrwweb
Copy link

mrwweb commented Oct 12, 2018

As made clear on #9156, there are a number of problems with the columns block. As the targeted release date quickly approaches, I find the continued inclusion of the columns block (even with the "Beta" label) quite confusing.

Will that block be included in the first release of Gutenberg with WordPress? If so, I worry that it over-promises and under-delivers, giving people the wrong impression of the quality and reliability of the new editor. I can't think of a single feature in WordPress that was released in such a problematic beta state.

On the other hand, a columns block will be incredibly useful and is a great example of the advantages of block-based editing.

Either the columns block should get pulled or it should be considered a blocker and significantly improved before release.

@GlennMartin1
Copy link

This #10541 is a step in the right direction, and is slated for 4.1.

I would like to see variable column widths in 5.0; is there a chance that will be included?

@mtias
Copy link
Member

mtias commented Oct 12, 2018

I would like to see variable column widths in 5.0; is there a chance that will be included?

Likely not. We are trying the mechanism in #9416 which should be included in 5.0, but with a more constrained scope. If it works well we can add this in a minor release later on.

Either the columns block should get pulled or it should be considered a blocker and significantly improved before release.

This is very fuzzy to plan around. What specifically needs to be improved? There are many features we can add to it, but they are not crucial for a first version. The main focus is on fixing any outstanding bugs and clarifying the selection of parent / child combinations: #9628

@mrwweb
Copy link
Author

mrwweb commented Oct 12, 2018

What specifically needs to be improved?

#9156 has a good list. Highlights:

Overall, this block just feels confusing across the board, and I'm not sure that putting a "beta" flag in the title helps a great deal, particularly when the entire software is still in some form of beta or another.

Selecting elements (especially the RIGHT element) is very confusing.

Column block followed by another column block creates overlap.

I haven't tested the very latest release, but in the 3.9.0 plugin release, there were overlapping outlines, I struggled to click in the right place to add content to the 2nd column, and I don't see a button to add another block below the first one in a column.

I'm not really clear what the intended featureset of the columns block is intended to be. It's extremely hard to give good feedback without understanding the intended features. (Maybe that could be added to all the Block Audits?) but I think it needs to not have any major usability problems of the types mentioned if it's going to be included.

@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Oct 12, 2018
@danielbachhuber danielbachhuber added [Type] Question Questions about the design or development of the editor. [Feature] Blocks Overall functionality of blocks labels Oct 12, 2018
@mtias mtias added the [Block] Columns Affects the Columns Block label Nov 1, 2018
@mtias mtias modified the milestones: WordPress 5.0 RC, WordPress 5.0 Nov 12, 2018
@mtias
Copy link
Member

mtias commented Nov 15, 2018

Further improvements have landed in #11659 and #11904. @mrwweb would you mind testing with latest master to see how it feels?

I'm not really clear what the intended featureset of the columns block is intended to be.

Columns was originally not planned for 5.0, it was used to refine the hidden architecture around nested blocks. In the process — and the delaying of launching phase 1 — it continued to evolve and people started using them for cool integrations to the point that it became almost an expected feature.

For 5.0, the Columns Block needs to:

  • Support adding blocks inside different columns.
  • Support adding new columns.
  • Integrate with "block navigator" for selecting single columns and the wrapper.
  • Support adding classes to the wrappers.
  • Be decently responsive on mobile.
  • Have columns of equal widths (in the future it should be resizable / configurable).
  • Not have major usability problems (like not being able to select a block, or breaking the editor layout).

@mrwweb
Copy link
Author

mrwweb commented Nov 16, 2018

Haven't been able to test this yet @mtias. Will it be on beta5?

@jasmussen
Copy link
Contributor

jasmussen commented Nov 16, 2018

Will it be on beta5?

That branch was merged into Gutenberg 4.4 which will form the basis for beta 5, yes.

@mtias
Copy link
Member

mtias commented Nov 19, 2018

Yes, it was included in beta 5.

@mrwweb
Copy link
Author

mrwweb commented Nov 20, 2018

Tested and left feedback on #11159.

I'm disappointed to report that there was no noticeable improvement on any of the issues I ran into, which mostly involved the initial states of the columns.

@designsimply designsimply removed the [Feature] Blocks Overall functionality of blocks label Nov 26, 2018
@mtias
Copy link
Member

mtias commented Nov 29, 2018

Closing this, consolidating in #11159. The main fix discussed there is ready but won't be landing until 5.0.1.

@mtias mtias closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

6 participants