-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a headings hierarchy checker notice in the heading block sidebar #10581
Comments
This is a great idea. |
Thinking about this, one thing I've found quite common is to have the ability to visually style one heading as though it were another heading level. For example, say for some reason we need the 2nd level heading on the page to look like the I know this sounds a bit odd, but in my experience, it's common that designs have headings that don't always visually follow the ideal hierarchical structure. This might help us avoid incorrect heading hierarchies. The issue I raised about this has been superseded. |
Yes! Ideally should work like all the other notices: when they appear, they should also be announced with |
I really like @melchoyce's suggestion above. Let's get this developed @youknowriad. |
I like the suggestion from @melchoyce. The wording should probably be adjusted - in the example context, either an h2 or an h3 would be valid. I think that there are two paths we can take with the error message: either make it more generic, or more specific. With any given heading, it can always be followed by a heading that's of the same or any higher level (excepting h1, as that should only be used once on any page) or by the heading immediate lower. "higher" and "lower" levels of headings is ambiguous, however, which makes referencing these generically somewhat difficult. Making it specific will on rare occasion mean listing a large number of heading levels - but only in relatively rare cases, where somebody is actually using h4. (There are no invalid heading levels that can follow an h5 or an h6) |
I am removing the 'User Experience (UX)' label as part of a label cleanup. It's not being used anymore consistently so let's try and keep to 'needs design' and 'needs design feedback'. If we find a need for another label we can consider it but having those 2 should cover this. |
also discussed in #20870 |
Previously, the headings hierarchy was placed also in the Document sidebar, in the "Table of Contents" panel:
This panel has been removed so the only way to be aware of the incorrect headings level is to intentionally check the document outline tool in the top bar.
I'd like to propose to add a notice, even a small one, directly in the Heading block sidebar so users will be immediately informed the hierarchy is not correct while they set the heading level. An option might be placing the notice under the buttons in the sidebar:
The text was updated successfully, but these errors were encountered: