Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip_dynamic_blocks is removed from the wrong priority, dynamic blocks are not rendered #11056

Closed
woutervanvliet opened this issue Oct 25, 2018 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@woutervanvliet
Copy link

Describe the bug
The strip_dynamic_blocks_add_filter adds a filter to remove dynamic blocks from the excerpt, and schedules a next filter to remove strip_dynamic_blocks again.

However, it appears the priority of do_blocks seems to have changed, and thus also all the filters that should be run before do_blocks. The removal of strip_dynamic_blocks however was not changed.

Now, lib/blocks.php line 296 adds the filter at 6, line 316 still removes it at 8 - as a result no dynamic blocks are rendered anymore, at all.

Appears in version 4.1.0

@youknowriad
Copy link
Contributor

yes, it should be closed by #11050

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Oct 25, 2018
@woutervanvliet
Copy link
Author

Yes, looks like that PR indeed solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants