Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions button when there are no revisions #1108

Closed
afercia opened this issue Jun 10, 2017 · 1 comment
Closed

Revisions button when there are no revisions #1108

afercia opened this issue Jun 10, 2017 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jun 10, 2017

The revisions link introduced in #910 works great when there are revisions: it's a link and points to the Revisions screen.

However, when there are no revisions:

screen shot 2017-06-10 at 15 00 27

it's a button, it's focusable and actionable, but it doesn't do anything. Not completely sure abot what to do here. The ARIA Authoring Practices allow disabled controls (or, in this case, a control that doesn't do anything) to still be focusable when this helps discoverability. See https://www.w3.org/TR/wai-aria-practices/#kbd_disabled_controls

On the other hand, the fact it's reported as "button" when there are no revisions, and then reported as "link" when there are revisions, could be potentially confusing.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 10, 2017
@adamsilverstein
Copy link
Member

Fixed in #1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants