-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlighted formatting in the toolbar doesn't match MCE inline boundaries #11091
Comments
@iseulde - I've noticed this issue, but not sure what the best way to solve it is. Let me know if you have any ideas. |
@talldan What's the behaviour in TinyMCE? |
Hi @iseulde, It's a bit inconsistent in classic. It works as I would expect for links. The format is shown toggled on in the toolbar if the caret is on either the left or right side of the formatted text. With bold, italics and strikethrough, it's the opposite to what we have in Gutenberg, at the end of the formatting the toolbar button is shown toggled on, but at the start it's toggled off. |
@iseulde Seems sensible. |
I noticed a similar issue in 4.2-RC. Originally reported in #11326. To Reproduce
Expected behavior Desktop:
|
This needs to be addressed in #11322. In other words, we need to make the rich text value boundary-aware. |
Duplicates: #11326, #13087.
Describe the bug
There's a minor inconsistency with the formatting toolbar and TinyMCE's inline boundaries (used to highlight formatted text).
When the caret is positioned on the left side of formatted text, within the inline boundary, the toolbar button for the active formatting is correctly shown toggled on:
Pressing the left arrow key once to move the caret outside of the inline boundary, the format is incorrectly still shown toggled on:
Positioning the caret on the right side of formatted text, back within the inline boundary, the toolbar button is incorrectly toggled off:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The toggle state of toolbar formats should match the position of the caret.
Additional context
The text was updated successfully, but these errors were encountered: