-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolding part of a heading has no visual indication #11107
Comments
This is not different at all from the old editor. I have recommended in the past for the default stylesheet and themes to handle bold in headings to e.g. increase or decrease (if no increase is possible) the font weight of the text so that it is visually different. This is more of a theme issue. |
I like this idea. The default for me would be to just not show bold unless there is a style. Let's consider iteration on this in 5.0.1 |
I've discovered some bugs with this. What I did was:
Then, things got really interesting. I tried to replicate this behavior in another post
oops now the heading text is gone... |
@hedgefield The problem you're reporting seems unrelated to this issue. Could you create a new issue? As for the problem reported here, it's purely a theme issue I think, and in my opinion, it should be addressed by themes that decide to increase font weight for heading text. They increase the default font weight, so it's their responsibility to account for
I would recommend adding a section on this in a theme handbook, and perhaps fix the core themes and _s. Unfortunately, this is not something we can fix in the editor.
Feel free to reopen the issue if you disagree with this. |
When bolding part of a heading, this has no effect on the visual appearance of the heading:
There's a
<strong>
tag that gets wrapped around the section of "bolded" text, but because the heading is already displayed at the 600 weight, and Noto Serif only has two weights, there's no visual indication of what is and what isn't bolded.Theoretically of course, you could be using a theme that either a) doesn't bold-by-default its headings or b) uses a heading typeface with multiple weights. However, I suspect that for most themes, that's unlikely to be the case, and the bolding would have no effect. I tested in a bunch of themes and:
in twentyfifteen bold text appears in a lighter weight:
in twentysixteen the bold text is the same weight:
in twentyseventeen the bold text is bold:
in twentynineteen the bold is bold:
in Atomic Blocks, it's the same weight:
in the Gutenberg starter theme, it's the same weight:
and the same in _s as well:
(Note: the latter two seem to be using browser default weights for heading elements, ie, they aren't explicitly set to a particular weight via the CSS, but the
<strong>
is set to 700, which seems like it might be introducing some faux-bolding but I could also be hallucinating it.)There are a few ways to resolve this, all of which have drawbacks (what fun!):
The text was updated successfully, but these errors were encountered: