Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Editor Inserter Menu, 'Paragraph' block is kept at the top of 'Most Used'. #11400

Closed
shinyabw opened this issue Nov 2, 2018 · 2 comments
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface

Comments

@shinyabw
Copy link
Contributor

shinyabw commented Nov 2, 2018

Describe the bug

In Editor Inserter Menu, 'Paragraph' block is kept at the top of 'Most Used'.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Editor Inserter Menu'
  2. Use 'Particular-non-Paragaraph block' more than 'Paragaraph' block
  3. Go to 'Editor Inserter Menu.'
  4. See error; 'Paragraph' block is still shown (kept) at the top of 'Most Used'.

Expected behavior

Once a particular block is used more than 'Paragraph' block, this 'Paticular' block should be shown before 'Paragraph' block.

Screenshots

most-used

Desktop (please complete the following information):

  • OS: [Mac 10.13.6]
  • Browser [Firefox]
  • Version [63.0.1]

Additional context

  • 4.2.0-rc.1
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 2, 2018
@designsimply
Copy link
Member

Thank you for testing! I tested with WordPress 4.9.8 and Gutenberg 4.2.0-rc.1 and can confirm that the paragraph block always appears first under "Most Used" in the inserter. I also found that this is by design. You can see it mentioned in #2836 (2nd paragraph).

I am closing this issue and if you feel strongly that it would be good to get another design feedback on it, please let me know and we can re-open.

@designsimply designsimply added [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface and removed Needs Testing Needs further testing to be confirmed. [Feature] Blocks Overall functionality of blocks labels Nov 2, 2018
@shinyabw
Copy link
Contributor Author

shinyabw commented Nov 5, 2018

@designsimply Thank you for testing this. Thank you for finding #2836. I see... Paragraph block is still hardcoded. Since it is intentional, I would like to think about this issue a bit more.

Quoting from #2836:

This also keeps a "highscore table" of block usage, so in a future PR, we can use this data to display the user's most frequently used blocks next to the inserter, where we currently hardcode paragraph and image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

No branches or pull requests

2 participants