Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video embed: Video not aligning correctly. #11441

Closed
paaljoachim opened this issue Nov 2, 2018 · 4 comments
Closed

Video embed: Video not aligning correctly. #11441

paaljoachim opened this issue Nov 2, 2018 · 4 comments
Labels
[Block] Embed Affects the Embed Block [Status] Needs More Info Follow-up required in order to be actionable. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Nov 2, 2018

Describe the bug
I selected to align video to center, but the frontend shows it on the left side of the screen.
The caption is seen in the center of the screen

screen shot 2018-11-03 at 13 54 54

To Reproduce
Steps to reproduce the behavior:

  1. Add a youtube video.
  2. Add a caption.
  3. Save/preview and check out where the video and caption is located.
  4. Video is located on the left side of the screen. Caption is in center of page.

Expected behavior
That aligning center also aligns the video in the center of the screen. With the caption in alignment below it.

Screenshots

Gutenberg - backend. Showing caption and video.
screen shot 2018-11-02 at 22 55 00

Frontend:

Showing caption too far to the right.
screen shot 2018-11-02 at 22 55 13

Desktop (please complete the following information):

  • Mac OS 10.13.6
  • Browser Chrome and Desktop Server
  • Gutenberg version 4.1.1
@paaljoachim paaljoachim changed the title Video embed: Caption not aligning to video Video embed: Caption not aligning to video + video not reflecting alignment Nov 3, 2018
@paaljoachim paaljoachim changed the title Video embed: Caption not aligning to video + video not reflecting alignment Video embed: Video not aligning correctly. Caption aligns correctly. Nov 3, 2018
@paaljoachim paaljoachim changed the title Video embed: Video not aligning correctly. Caption aligns correctly. Video embed: Video not aligning correctly. Nov 3, 2018
@ocean90 ocean90 added the [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. label Nov 3, 2018
@swissspidy swissspidy added the [Block] Embed Affects the Embed Block label Dec 12, 2018
@youknowriad
Copy link
Contributor

There has been a lot of work on embeds since the issue has been created, Is this still an issue?

@youknowriad youknowriad added the [Status] Needs More Info Follow-up required in order to be actionable. label Dec 25, 2018
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jan 4, 2019

I just tested it again. The caption is now showing up correctly.

@youknowriad
Copy link
Contributor

Nice, thanks for the update.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Feb 5, 2019

Btw We have the same issue for images. Caption not aligning correctly.
I will open a new issue if there is not one already in existence.

I find it interesting that caption for video follows nicely wherever the video is aligned. In the backend and frontend. But the image is another matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Status] Needs More Info Follow-up required in order to be actionable. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

4 participants