Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink edit section inherits styles brought in from add_theme_support( 'editor-styles' ) #11503

Closed
laurelfulford opened this issue Nov 5, 2018 · 1 comment
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it Needs Testing Needs further testing to be confirmed.

Comments

@laurelfulford
Copy link
Contributor

Describe the bug
The permalink link area can inherit link styles set in a theme's classic editor styles, when they're pulled into to the new editor using add_theme_support( 'editor-styles' ).

A more specific selector, and some proactive styles should help fix, though it looks like it could be easy to end up with some redundant CSS.

This issue is similar to #11132; @afercia spotted it when reviewing changes to Twenty Seventeen, here: https://core.trac.wordpress.org/ticket/45246#comment:4

To Reproduce
Steps to reproduce the behavior:

  1. Start with a theme that uses add_theme_support( 'editor-styles' ) to pull classic editor styles into Gutenberg. Any of the older default themes (Ten thru Seventeen) from the WordPress 5.0 beta will work.
  2. Open an existing page or post.
  3. Click on the post title to view the permalink.

Expected behavior
That this space would use the same fonts, colours, and styles of other Gutenberg elements.

Actual behavior
This space can inherit colours (on both the link and button), and font family, as well as odd things it doesn't set, like borders (Twenty Fifteen) or box-shadows (Twenty Seventeen).

Screenshots
All default themes exhibit some level of issue:

Twenty Seventeen: inherits colour and box shadow (for underline)
twenty-seventeen-permalinks

Twenty Sixteen: inherits colour
twenty-sixteen-permalinks

Twenty Fifteen: inherits colour and bottom border (for underline)
twenty-fifteen-permalinks

Twenty Fourteen: inherits colour on link and button
twenty-fourteen-permalinks

Twenty Thirteen: inherits colour on link and button
twenty-thirteen-permalinks

Twenty Twelve: inherits colour on link
twenty-twelve-permalinks

Twenty Eleven: inherits colour, font styles
twenty-eleven-permalinks

Twenty Ten: inherits colour on link and button, and font family
tweny-ten-permalinks

Additional context
Can recreate with the Gutenberg 4.2 RC, and the current version in the repo as of commit c8b4679.

@designsimply designsimply added General Interface Parts of the UI which don't fall neatly under other labels. Needs Testing Needs further testing to be confirmed. [Feature] Permalink The permalink of a post or page and the experience of setting or editing it and removed General Interface Parts of the UI which don't fall neatly under other labels. labels Nov 6, 2018
@youknowriad
Copy link
Contributor

We have a new panel for permalinks now #11874. We didn't remove this UI yet because we're passed UI freeze but it should be considered deprecated. I'm considering this as a wont fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

3 participants