Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Add 2nd Inline Format When Type (Nested Bold & Italic While Typing) #11743

Closed
mrwweb opened this issue Nov 11, 2018 · 1 comment · Fixed by #14411
Closed

Cannot Add 2nd Inline Format When Type (Nested Bold & Italic While Typing) #11743

mrwweb opened this issue Nov 11, 2018 · 1 comment · Fixed by #14411
Labels
[Package] Rich text /packages/rich-text [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@mrwweb
Copy link

mrwweb commented Nov 11, 2018

To Reproduce

  1. Start typing.
  2. Enable italic via CTRL + I or clicking the italic button
  3. Type a bit in italic
  4. Attempt to enable bold with CTRL + B or clicking the button
  5. Continue typing.

The exact buggy behavior seems to differ between browsers.

In Chrome, the current style (italic) is closed and the new one (bold) is started so you get italic text followed by bold text but not bold italic text.

In Firefox, the current style (italic) simply continues, ignoring the new one (bold), so you get only italic text. (Pictured below)

Notes:

  1. Attempting to record a GIF of this behavior with LiceCAP sometimes made it work, but not always (see below).
  2. Steps 2 and 4 above can be reversed and show the same issue.

Expected behavior
It is already possible to nest bold and italic if all the words are written and then formatted via text selection. I should be able to produce the same result as I write.

Screenshots
Firefox:
nested-bold-italic

Desktop (please complete the following information):
Win 10, Firefox 63 and Chrome 70 (behavior varies, see above), WP 5.0-beta3, Twenty Nineteen, no plugins.

@designsimply designsimply added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. labels Nov 11, 2018
@designsimply
Copy link
Member

I tested and confirmed with a few different browsers and had some varying results.

In Firefox, pressing "Bold" works but italics stops and I'm moved to the next line:

italic-and-bold-wp4 9 8-g4 3 0-rc 1-firefox63-macos

In Chrome and Safari, I see the same result as you, bold does not work if I'm already within an inline boundary for italics:

italic-and-bold-wp4 9 8-g4 3 0-rc 1-chrome-70-macos

(Safari gif)

Tested with WordPress 4.9.8 and Gutenberg 4.3.0-rc.1 on macOS 10.13.6. Note: I also tested with master 992a43cdd and saw the same result (i.e. Chrome+master).

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later and removed Needs Testing Needs further testing to be confirmed. labels Nov 12, 2018
@ellatrix ellatrix added [Package] Rich text /packages/rich-text and removed [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Rich text /packages/rich-text [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants