Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console errors in Gutenberg 4.4. #11977

Closed
spacedmonkey opened this issue Nov 16, 2018 · 7 comments
Closed

Console errors in Gutenberg 4.4. #11977

spacedmonkey opened this issue Nov 16, 2018 · 7 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended

Comments

@spacedmonkey
Copy link
Member

Describe the bug
When I load gutenberg (4.4) in browser, I get a high number console errors. See screenshot.

To Reproduce
Steps to reproduce the behavior:

  1. Open post edit screen in browser.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS: OSX 10.13.6
  • Browser Chrome
  • Version: 70.0.3538.102

Additional context

  • Gutenberg 4.4
  • Yoast SEO 9.1
@tofumatt
Copy link
Member

Any chance this is related to the recent React upgrade in #11840? cc @gziolo @youknowriad

@tofumatt
Copy link
Member

Seems like this'd be fixed by #11360. These warnings don't imply anything is broken, for what it's worth. We just have to update our code to move to new APIs 😄

@tofumatt tofumatt added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 16, 2018
@youknowriad
Copy link
Contributor

yes, it is related most of these are not coming from Gutenberg thought but more from plugins using deprecated APIs, Gutenberg itself is still using one or two deprecated APIs (the first warning I think). I'm closing this as a duplicate of #11360 but at the same time you should try to reach out the plugin authors using these too.

When it comes to the React update, it didn't add any new warnings to Gutenberg itself.

@spacedmonkey
Copy link
Member Author

Looking into this, I am only seeing this when define( 'SCRIPT_DEBUG', true ); Even so, I get over 200 errors in console, seems like a lot. It seems to be linked to react-dom

@tofumatt
Copy link
Member

tofumatt commented Nov 16, 2018 via email

@spacedmonkey
Copy link
Member Author

Below is screenshots from a fresh install of WordPress 4.9.8 with no other plugins than gutenberg.

image
image

@youknowriad ^

@youknowriad
Copy link
Contributor

Yes, nothing really concerning, but it should be fixed when #11360 is closed.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended Framework Issues related to broader framework topics, especially as it relates to javascript and removed [Type] Code Quality Issues or PRs that relate to code quality labels Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants