Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block: Update Poster Image UI #11991

Closed
melchoyce opened this issue Nov 16, 2018 · 5 comments
Closed

Video Block: Update Poster Image UI #11991

melchoyce opened this issue Nov 16, 2018 · 5 comments
Labels
[Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.

Comments

@melchoyce
Copy link
Contributor

melchoyce commented Nov 16, 2018

Based on some work on #7673 and #9457, I want to propose an updated UI for the Poster Image feature in the Video Block:

video block - poster image

This would:

  • Split it out into its own sidebar panel
  • Show a preview of the selected image
  • Change the "replace" button styling into link styling and simplify the label
  • Right align the "remove" link and simplify the label
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Block] Video Affects the Video Block labels Nov 16, 2018
@Soean Soean self-assigned this Nov 16, 2018
@Soean
Copy link
Member

Soean commented Nov 18, 2018

@melchoyce If we change this UI, we should also change it for the featured image. Maybe we should also add a drag&drop area?
We should include the A11y team in this discussion, so I added the label.

Current Video Settings
bildschirmfoto 2018-11-18 um 17 22 52
bildschirmfoto 2018-11-18 um 17 22 26

Current Featured Image settings
bildschirmfoto 2018-11-18 um 17 09 07

bildschirmfoto 2018-11-18 um 17 09 31

@Soean Soean removed their assignment Nov 18, 2018
@Soean Soean added the Needs Accessibility Feedback Need input from accessibility label Nov 18, 2018
@afercia
Copy link
Contributor

afercia commented Nov 23, 2018

We've discussed a bit this issue during today's accessibility bug scrub but haven't came to a conclusion. We'll look a bit better next week, thanks 🙂

@afercia
Copy link
Contributor

afercia commented Nov 30, 2018

Discussed during today's accessibility bug scrub and we'd recommend a consistent pattern with the featured image as @Soean pointed out.

Also to consider the position of the buttons: ideally they should be close to each other for the "proximity of controls" principle, see https://core.trac.wordpress.org/ticket/40822

Lastly, preferably use more explicit buttons text to describe what the buttons do.

The buttons should probably also be updated to "Replace Poster Image" and "Remove Poster Image"

@afercia afercia removed the Needs Accessibility Feedback Need input from accessibility label Nov 30, 2018
@melchoyce
Copy link
Contributor Author

Let's go with the existing pattern, and consider exploring a redesign of the pattern at a future time.

@Soean
Copy link
Member

Soean commented Jun 20, 2019

We go with the existing pattern, so I am closing this issue.

@Soean Soean closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants