-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Block: Update Poster Image UI #11991
Comments
@melchoyce If we change this UI, we should also change it for the featured image. Maybe we should also add a drag&drop area? |
We've discussed a bit this issue during today's accessibility bug scrub but haven't came to a conclusion. We'll look a bit better next week, thanks 🙂 |
Discussed during today's accessibility bug scrub and we'd recommend a consistent pattern with the featured image as @Soean pointed out. Also to consider the position of the buttons: ideally they should be close to each other for the "proximity of controls" principle, see https://core.trac.wordpress.org/ticket/40822 Lastly, preferably use more explicit buttons text to describe what the buttons do.
|
Let's go with the existing pattern, and consider exploring a redesign of the pattern at a future time. |
We go with the existing pattern, so I am closing this issue. |
Based on some work on #7673 and #9457, I want to propose an updated UI for the Poster Image feature in the Video Block:
This would:
The text was updated successfully, but these errors were encountered: