Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button color settings overridden in Twenty-* themes. #11998

Closed
m-e-h opened this issue Nov 16, 2018 · 4 comments
Closed

Button color settings overridden in Twenty-* themes. #11998

m-e-h opened this issue Nov 16, 2018 · 4 comments
Labels
Needs Testing Needs further testing to be confirmed.

Comments

@m-e-h
Copy link
Member

m-e-h commented Nov 16, 2018

Describe the bug
As mentioned in #11779 (comment)
The Twenty-* themes are overriding the core button styles such as .wp-block-button__link:not(.has-background). But they're doing it with an equally specific selector that also overrides the "utility" class applied for the color .has-pale-pink-background-color.

By relying on :not() to allow for color overrides, we're assuming everyone else will, as well.
Using :not() to style a button wouldn't be my first instinct.
Also discussed here #11677

To Reproduce
Steps to reproduce the behavior:

  1. Add a button in Twenty Seventeen or Twenty Sixteen from the WP 5.0 Branch.
  2. Color the background and text color of the button.
  3. Check it out on the front end.

Additional context

  • Gutenberg v4.4
@m-e-h m-e-h mentioned this issue Nov 16, 2018
4 tasks
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 18, 2018
@designsimply
Copy link
Member

Testing note: check to see if it happens in the plugin independently of WP5.0-betas.

@m-e-h
Copy link
Member Author

m-e-h commented Nov 18, 2018

This only happens when a theme explicitly sets the color or background on .wp-block-button__link.

So it would only be a problem for the betas of the Twenty-* themes since the previous versions don't have any Gutenberg styles.

@m-e-h
Copy link
Member Author

m-e-h commented Nov 20, 2018

This can probably be closed with the fix in #12005
But the default themes are still going to have to adjust their CSS to allow for the Button Color settings to take affect.

@youknowriad
Copy link
Contributor

Thanks @m-e-h Awesome work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

3 participants