Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform a full save when previewing drafts #12047

Closed
adamsilverstein opened this issue Nov 19, 2018 · 1 comment · Fixed by #12097
Closed

Perform a full save when previewing drafts #12047

adamsilverstein opened this issue Nov 19, 2018 · 1 comment · Fixed by #12097
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended

Comments

@adamsilverstein
Copy link
Member

adamsilverstein commented Nov 19, 2018

Describe the bug
When clicking the preview button for draft posts, Gutenberg should save all post details, including meta fields and the featured image. Currently Gutenberg performs an autosave when previewing drafts, which includes title, content and excerpt and leaves out meta and featured image information.

To Reproduce
Steps to reproduce the behavior:

  1. Start a new post, add a title and a featured image and click save draft
  2. Change the featured image to a new image
  3. Click the preview button
  4. Reload the editor screen

Expected behavior
At step 3 we should see the newly selected featured image in the preview - instead we see the first/saved image.
At step 4 we should see the new featured image because it was saved when previewing; instead we see the original image.

Note: saving the full post information for drafts when previewing matches the current classic editor behavior.

Additional context
See #12037 (comment) which solves featured image issue for non draft posts
Related: #11409 (which does not resolve this issue)
Related featured image issue: #9151

@earnjam
Copy link
Contributor

earnjam commented Nov 19, 2018

Sort of related to save vs autosave and previews: #7927
And some work is being done on that in #7953

@earnjam earnjam added the [Feature] Saving Related to saving functionality label Nov 19, 2018
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 19, 2018
@gziolo gziolo added this to the WordPress 5.0 RC milestone Nov 20, 2018
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. [Type] Enhancement A suggestion for improvement. labels Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants