Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables block - BUG: Arrow keys not working as expected... #12114

Closed
GlennMartin1 opened this issue Nov 20, 2018 · 5 comments · Fixed by #14462
Closed

Tables block - BUG: Arrow keys not working as expected... #12114

GlennMartin1 opened this issue Nov 20, 2018 · 5 comments · Fixed by #14462
Labels
[Block] Table Affects the Table Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@GlennMartin1
Copy link

Describe the bug

In the Tables block:

  • DOWN arrow doesn't do anything (should move down a block)
  • UP arrow doesn't move up (instead, it moves left, only every-other-time)
  • LEFT arrow button only works in empty cells

Gutenberg 4.4

@Soean Soean added Needs Testing Needs further testing to be confirmed. [Block] Table Affects the Table Block labels Nov 20, 2018
@designsimply
Copy link
Member

I tested with Gutenberg master using Firefox 63.0.1 on macOS 10.13.6 and found slightly different behavior:

  • Left or down key traverses table cells across rows and then to the previous row.
  • Right or down arrow key traverses table cells across rows and then to the next row.
  • Up and down arrow keys require two key presses for empty cells.

Video: 1m25s
Tested with WordPress 4.9.8 and Gutenberg 4.4 5a8c012de using Firefox 63.0.1 on macOS 10.13.6.

Noting: would be nice to have additional testers make a note in the comments of their browser version if they try from another browser.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Nov 20, 2018
@GlennMartin1
Copy link
Author

Testing in Windows with Chrome 70.0.3538.102

Revision to original post:

RIGHT:

  • after mouse clicking in an empty cell, RIGHT does nothing.
  • except, works normally IF there is content in the cells, or IF you first navigate LEFT then RIGHT

LEFT:

  • works normally

DOWN:

  • doesn't do anything in an empty cell
  • except, if there's content in the cell, then DOWN moves RIGHT

UP:

  • works normally in cells with content,
  • except require two key presses for empty cells

@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Nov 21, 2018
@mtias mtias added this to the WordPress 5.0.x Follow Ups milestone Nov 21, 2018
@mtias mtias added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Nov 21, 2018
@GlennMartin1
Copy link
Author

This is clearly a bug (not enhancement) - and the BUG label should be applied.

@designsimply
Copy link
Member

To try to help explain (this is my hunch), I bet it's considered an enhancement because it's not something that was explicitly added and then broke—I think it's that it wasn't expected to work at all before and so adding a way for it to work is an improvement not fixing something that exists that's broken. It really can be a fine line sometimes though!

@GlennMartin1
Copy link
Author

As of Gutenberg 5.3, behavior is far better; this issue is no longer current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants