Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage Image Sizes Don't Make Sense, Result in Weird Behavior #12276

Closed
mrwweb opened this issue Nov 24, 2018 · 1 comment
Closed

Percentage Image Sizes Don't Make Sense, Result in Weird Behavior #12276

mrwweb opened this issue Nov 24, 2018 · 1 comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@mrwweb
Copy link

mrwweb commented Nov 24, 2018

Describe the bug
As presented and functioning right now, I don't think the image percentage feature should be included with the 5.0 release.

Primarily, it's quite opaque to the user what the percentage is relative to and how it is calculated. As mentioned #11530, it would at least make more sense (though I'm still not sure if it would warrant inclusion) if it were relative to content width and an alternative to the named sizes rather than being a percentage of the named size.

Some of the odd behaviors and problems that result what seems like the intended behavior:

  • If an image size is larger than the full width, the image is constricted to full width at first, but clicking a percentage less than 100% can make it BIGGER! (See also: Image with size breaks out of editor block #12168)
  • A "25%" image set relative to the Large size could quite possibly be larger than 100% of a medium or thumbnail image. This just feels weird.
  • The percentage sizing is "lost" when changing from one named image size to another. This has an internal logic to it, but feels quite odd in practice. This is at least partially due to the fact that the percentages are broken away from the Sizes select menu by the pixel size controls.
  • This likely will encourage inconsistency across a site with multiple editors. It seems very plausible that one editor would use "Medium" images while another might use a "Large" image at 50%. What would the impact of that be long-term.
  • I don't know how this will impact the output of a sane sizes attribute, but it seems like it adds another layer of complexity to an already-challenging issue.

Screenshots
GIF showing strange behavior described in first point above in which 75% and 100% of a "Large" image are both larger than the initially inserted image.

percentage-image-sizes

Screenshot showing interface that divides a primary control from a means of modifying the selection.
Image Size and Percentage controls should be next to each other if the percentage controls are a means of modifying the named size

Desktop (please complete the following information):
Win 10, WP 5.0-RC1, Firefox 63.0.3, Twenty Nineteen, No plugins

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Nov 24, 2018
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media [Block] Image Affects the Image Block and removed [Type] Bug An existing feature does not function as intended labels Dec 5, 2018
@youknowriad
Copy link
Contributor

I'm to close this as a duplicate of #11530 as it seems to refer to the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants