Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size picker small accessibility improvements #12371

Closed
afercia opened this issue Nov 27, 2018 · 0 comments
Closed

Font size picker small accessibility improvements #12371

afercia opened this issue Nov 27, 2018 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Nov 27, 2018

I'd like to propose a couple small accessibility improvements for the font size picker:

screenshot 2018-11-27 at 20 00 05

Right now, there's no semantic indication of the currently selected font size:

  • the toggle button could include this info in its aria-label
  • the menu items should use an ARIA role menuitemradio, as this menu allows for a single choice
  • add an aria-checked attribute based on the selected item
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 27, 2018
@afercia afercia mentioned this issue Nov 27, 2018
Merged
@designsimply designsimply added the [Type] Enhancement A suggestion for improvement. label Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@designsimply @afercia