Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad sidebar style (no spacing) #12652

Closed
manake opened this issue Dec 6, 2018 · 2 comments · Fixed by #13181
Closed

Bad sidebar style (no spacing) #12652

manake opened this issue Dec 6, 2018 · 2 comments · Fixed by #13181
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@manake
Copy link

manake commented Dec 6, 2018

I really don't know why do I see things like this by default in Gutenberg (I don't load any custom admin styles whatsoever):

The following should be removed to fix this, I don't know why it's even there?

.components-base-control .components-base-control__help {
    font-style: italic;
    margin-bottom: 0;
    margin-top: -8px;
}

/wp-content/plugins/gutenberg/build/components/style.css

Then the style is fixed.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Dec 7, 2018
@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 25, 2018
@geekpulp
Copy link
Contributor

@manake Is the intention to create space below each of the descriptions that are in italics? or that and remove the italics style too? I’m new to contributing to any project but I think I can do either of those if you can confirm which it is?

Thanks!

@manake
Copy link
Author

manake commented Jan 15, 2019

Italic is OK in my opinion because it doesn't violate any rule.

But spacing could be increased because it violates proximity rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants