Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So many embed blocks o my.. #1289

Closed
paaljoachim opened this issue Jun 20, 2017 · 1 comment
Closed

So many embed blocks o my.. #1289

paaljoachim opened this issue Jun 20, 2017 · 1 comment

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 20, 2017

Having a video, audio and image block as pillars for embeds would be great.
Having an embed for a lot of sites that a person might use does not seem logical to me. It really crowds up the Block space.

When the user needs to embed a video they can pick video embed. Then add the url to whichever site they are taking it from. The block should then just recognize the url and insert the correct code to get it to work. If for whatever reason it does not work then a generic message can show up saying the site is not supported or something similar.

@jasmussen
Copy link
Contributor

We are discussing how to add tabs to the inserter in #983 (comment) (though perhaps we should open a separate issue for it, what do you think @jwold?)

However the individual aliases for embeds are not going away. They are intentionally there to surface the embed features, and solve one of the key goals of the editor focus:

The editor will endeavour to create a new page and post building experience that makes writing rich posts effortless, and has “blocks” to make it easy what today might take shortcodes, custom HTML, or “mystery meat” embed discovery.

The "mystery meat" discovery is this. Very few people know how much WordPress supports out of the box. By putting explicit block links in the inserter we fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants