Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with Dragging to Select Text #13026

Closed
markarms opened this issue Dec 19, 2018 · 8 comments
Closed

Inconsistency with Dragging to Select Text #13026

markarms opened this issue Dec 19, 2018 · 8 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement.

Comments

@markarms
Copy link

Is your feature request related to a problem? Please describe.

My biggest difficulty with Gutenberg is that selecting and manipulating text is awkward -- I see different behaviors depending on where my mouse is located when I start to drag and select text on the screen. See the attached video -- different behaviors occur when:

-My mouse is hovering over the title or a blank block.
-My mouse is hovering over the left margin.
-My mouse is inside a block with text.

Video: https://markarmsdotcom.files.wordpress.com/2018/12/dragging-and-selecting-480.mov

So, when I drag to select text, it ends up selecting all of the blocks (not the text), or just the text, or nothing at all. All the while, this mouse movement is triggering the appearance of block outlines and the "add block" symbol both on the left of every block and in the center between each block.

Describe the solution you'd like

Right now it feels like I'm trying to manipulate text behind a thin layer of glass -- the blocks are constantly asserting themselves as the FOREMOST experience inside the editor. I would like to find a way for text manipulation, selection, and editing to become the FOREGROUND experience for all mouse movement inside the WordPress Editor. Let's assume by default that all mouse movement and behavior is related to text, UNTIL the user triggers an action that introduces blocks and block manipulation.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Dec 19, 2018
@designsimply
Copy link
Member

designsimply commented Dec 20, 2018

Thank you for asking about this! I would like to close in favor of #3629 which discusses cross-block selection and the issues you've raised and includes some notes about related design decisions as well as some of the technical implications about making a change.

If you think this issue should remain separate, please ask to re-open it with a note!

@markarms
Copy link
Author

Thank you @designsimply! I will stand down for now in favor of following #3629, but may reopen in the future.

@markarms
Copy link
Author

markarms commented Jan 8, 2019

Upon further reflection I think what I'm suggesting here is slightly different than issue #3629 so I'd like to re-open it. Thanks again @designsimply!

@designsimply designsimply removed the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jan 8, 2019
@designsimply designsimply reopened this Jan 8, 2019
@designsimply designsimply added the Needs Design Feedback Needs general design feedback. label Jan 8, 2019
@designsimply
Copy link
Member

Taking a closer look at why this issue may be different compared to #3629, I see that if you place the cursor on top of a text block and drag across more than one block then the blocks are selected and not the text and if you instead start your selection by placing the cursor to the left of a block and dragging then only the text is selected.

Regarding making text the foremost editing experience, some of the design decisions and reasoning behind the decision for the current implementation are outlined in #3629 which mentions some of the tradeoffs including benefits such as multi-selection actions like the ability to select 5 images and click a toolbar button to create a gallery of those. Or if you select 10 paragraphs, you can make it into a list or a quote. Or having block level controls such as movers, customization, drop-cap, etc. One of the downsides is you can't start a selection in the middle of one paragraph and end it in the middle of another. Issues around cross-block selection should continue being discussed in #3629 and I will leave this issue open for design review just looking at the part you raised about starting a selection from outside of a block working differently than starting a selection from within a block.

Aside: note that the title is not yet a block and there is a planned update to convert it into a block at #11553.

@jasmussen
Copy link
Contributor

Good ticket, this is definitely something to fix.

But this ticket is more about a bug in the current implementation, where if you make a selection that starts outside of the actual editing canvas, you are selecting HTML that has nothing to do with the editor. The obvious solution is to make sure that any drag action that happens inside the editing canvas invokes block selection, regardless of how that block selection might change depending on #3629.

@designsimply designsimply removed the Needs Design Feedback Needs general design feedback. label Jan 8, 2019
@bozzmedia
Copy link

Has there been any progress on this or #3629? This problem continues to hamper my editing within Gutenberg. Lots of clicking 3-4 times to select the right text. Quite frustrating when trying to get a lot of content editing done, especially in 2 column layouts.

@designsimply
Copy link
Member

Hi @bozzmedia. Thanks for chiming in and I'm sorry to hear you are frustrated! Progress for issues in this project are almost always noted at the bottom of the issue. Since nothing is showing up on this one, there hasn't been any attention to it. #3629, however, does seem to have some new work added but it is a draft format, which means developers are trying out some things and haven't settled on a solution yet.

@mtias
Copy link
Member

mtias commented Mar 28, 2022

Cross block text selection has been merged in #38892.

@mtias mtias closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants