-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gallery block's alignwide class is not removable after saving #13170
Comments
Thanks for checking it out @jorgefilipecosta ! I'm using TwentyNineteen v1.1 without any plugins active. You're correct that during the block manipulation a class is being added in the class name inserter. The thing is that I'm not adding it. It's getting added when I update the post. Here's a screencast of what I'm seeing https://drive.google.com/file/d/1WkwPtsA3c28OCz3n5WVRy-UmepivJRUA/view |
This one no longer seems to be an issue. I'll close, but @m-e-h, let me know if you're still experiencing this and I can reopen. |
Describe the bug
When "Wide width" is selected and saved for the gallery block, unselecting it doesn't remove the
alignwide
class in the editor or on the front-end.To Reproduce
Steps to reproduce the behavior:
alignwide
class remains.Expected behavior
alignwide
shouldn't be present when Wide width isn't selected.Screenshots
Related question: Why are we even adding these classes in the editor? https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/gallery/edit.js#L264
Shouldn't we be relying on
[data-align="wide"]
for these styles?Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: