Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Post Settings" button label #1356

Closed
GaryJones opened this issue Jun 22, 2017 · 21 comments
Closed

"Post Settings" button label #1356

GaryJones opened this issue Jun 22, 2017 · 21 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@GaryJones
Copy link
Member

GaryJones commented Jun 22, 2017

(Apologies if this has been previously discussed - I couldn't find any discussion.)

Screenshot showing button label as Post Settings when showing image block properties

The properties inspector for a block only appears when the Post Settings toggle button has been enabled - that's fine. But that means that the label of "Post Settings" doesn't make total sense - the screenshot above is really showing the immediate "settings" / "properties" of an image block, not the Post as a whole.

Something a bit more generic, like "Properties", or "Inspector" would make more sense for either context, and would then also apply without amendment when the editor is used for Pages or custom post types.

A few mockups:

  • Button label as Properties for image block

    Mockup showing button label as Properties for image block

  • Button label as Properties for Post Settings

    Mockup showing button label as Properties for Post Settings

  • Button label as Inspector for image block

    Mockup showing button label as Inspector for image block

  • Button label as Inspector for Post Settings

    Mockup showing button label as Inspector for Post Settings

There also comes the simplified ubiquitous language benefit to Users of being able to reference this thing called the "Inspector" in support queries and tutorials, in a similar way to understanding what the "Customizer" is, irrespective of whether the panel shows the Post Settings or some block settings (properties).

Discussion in #1100 (comment) explains how developers may visualise the topological implementation as being the block properties panel appearing as a modal over the top of the Post Settings, but that's not how a User (who doesn't know the code) will experience it.

@mtias
Copy link
Member

mtias commented Jun 22, 2017

Yes, this was discussed, and I believe I suggested using "Inspector" or "Block settings" at the time. I think @jasmussen has specific concerns with dynamically changing it based on what was selected, though.

@GaryJones
Copy link
Member Author

I would also have concerns about changing the button label dynamically, hence this proposal of choosing a static generic name, whatever contents are shown in the panel.

@buzztone
Copy link

As a new Gutenberg Editor user I definitely find "Post Settings" as the button label confusing.

For me "Inspector" conveys clearly what I see when I toggle this button. I have a clear mental image that it's letting me see the options available for the selected block in maximum detail.

@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement. labels Jun 22, 2017
@jasmussen
Copy link
Contributor

jasmussen commented Jun 22, 2017

For what it's worth, "Post Settings" has worked well on WordPress.com for about 4 months now. I think it's a good label because it contains exactly that, settings for the post that you're viewing.

Also, I strongly feel like we shouldn't dynamically change the label. Not only because it would cause everything to move around, but because I worry it'd add more confusion than it would alleviate. Changing the Publish button to "Update" when you're changing an already published post feels like an exception to this rule because it's an exceptional action.

@GaryJones
Copy link
Member Author

I think it's a good label because it contains exactly that, settings for the post that you're viewing.

For me, I think the smell that "Post Settings" for the button label is not a good name comes from the fact there are duplicate instances at the top:

screenshot 2017-06-22 17 09 10

If it was so good, why would the second instance (grey background) be needed? In this case, I think the second instance is correct, as would, for instance "Post -> Image", as it identifies exactly what the settings apply to - the post in general, or the image block.

That makes the ideal button label be one level of abstractness up, to represent the ability to toggle on this side panel or not - and not for what that side panel may or may not contain.

@westonruter
Copy link
Member

I'll note that “Post Settings” doesn't facilitate translations if to support multiple post types the underlying string is %s Settings into which the post's singular_label is supplied. See https://core.trac.wordpress.org/ticket/20005

@buzztone
Copy link

buzztone commented Jun 23, 2017

For what it's worth, "Post Settings" has worked well on WordPress.com for about 4 months now. I think it's a good label because it contains exactly that, settings for the post that you're viewing.

I'm really surprised that has worked well on WordPress.com. I would have thought that novice users would find the label confusing, especially if "Post Settings" is also used on Pages.

Also, I strongly feel like we shouldn't dynamically change the label.

I think there is a general consensus among current participants in this conversation that the label should not change. Rather the proposal I understand is to change to another single unchanging label which works well with all block types on both Posts & Pages.

That makes the ideal button label be one level of abstractness up, to represent the ability to toggle on this side panel or not - and not for what that side panel may or may not contain.

That's definitely how I interpreted this button - a toggle that let's me choose to see the maximum detail available on the block currently selected in the side panel, at top of the Gutenberg metaboxes selected in Screen Options.

2017-06-23_01

@jasmussen
Copy link
Contributor

especially if "Post Settings" is also used on Pages.

When editing pages, the label is "Page Settings".

@buzztone
Copy link

When editing pages, the label is "Page Settings".

Surely that's dynamically changing the label & at least potentially confusing for brand new users who don't understand yet the difference between a Page & a Post.

I'd be interested to hear from WordPress.com Happiness Engineers if new users have problems understanding the terms Post & Page.

@jasmussen
Copy link
Contributor

@buzztone

I would call that statically changing the label. [Eventually, not now] you click Pages -> Add New, and you are editing a page where the label says "Page Settings" and does so always. If you instead clicked Posts -> Add New, you'd get "Post Settings", which does not change so long as you are editing the post.

While I think "Post Settings" is descriptive for the sidebar toggle and works well, it is not the hill I will die on. I'm not immune to being convinced of other labels.

@GaryJones

If it was so good, why would the second instance (grey background) be needed? In this case, I think the second instance is correct, as would, for instance "Post -> Image", as it identifies exactly what the settings apply to - the post in general, or the image block.

The sidebar heading is for mobile, where the label on the button itself gets hidden.

@GaryJones
Copy link
Member Author

@buzztone

Surely that's dynamically changing the label

This is a different type of dynamic label - it's changing based on the post type (so stays the same in the editor view i.e. Post Settings vs Page Settings), and is not dependent on whether a block is selected or not (i.e. Post/Page Settings vs Block Settings).

It's still susceptible to some long Custom Post Type name in something like German blowing up the length of the button in a way that isn't catered for. That wouldn't happen if this button was named for what it was - a way to toggle the side panel, irrespective of what the contents of the panel were.

@buzztone
Copy link

buzztone commented Jun 23, 2017

That wouldn't happen if this button was named for what it was - a way to toggle the side panel, irrespective of what the contents of the panel were.

@GaryJones that's what appeals to me about your suggestion. You see this button in terms of this action. I think that's a view than many new users may take. The Publish/Update button beside it is clearly an action. Inspector or perhaps even Inspect works well if you think of the button in this way.

Post Settings or Page Settings (or even Properties) by contrast describes this button in terms of the viewable/editable settings shown when pressed. I can certainly see many users, particular existing WP users, being comfortable with this approach.

But it does seem to me carry a bit of cognitive overhead for brand new users. Ultimately user testing of new users will show if they understand what this button is for and click on it.

@jasmussen
Copy link
Contributor

In the native WordPress app, this panel is called "Settings":

screenshot_20170623-154628

Do you think people would grok this?

To me it feels like the "Post" aspect adds context.

@GaryJones
Copy link
Member Author

To me it feels like the "Post" aspect adds context.

But, for the WordPress app, that only shows the post settings, right? It doesn't also toggle the appearance of block settings as well?

@jasmussen
Copy link
Contributor

Right. So instead of having both a "Post Settings" and a "Block Settings" label, there's just "Settings".

The reason I come back to "Post Settings" (for posts) and "Page Settings" for pages (and so on for CPTs), is that I feel it's the one that best answers the question a novice user who accidentally dismissed the sidebar might ask: "where did my tags go"? I don't feel like any of the other labels suggested in this discussion answers this as well.

But again, I'm empathetic to the label being hard to translate — both length wise and wrt plurality etc., and I'm certainly open to a better suggestion. Naming things is hard.

@GaryJones
Copy link
Member Author

I agree, that for a question of "where did my tags go?", that "Post Settings" et al makes more sense than Inspector.

Likewise, screen info and help do describe what contents the User can expect to see in there.

Screenshot of Screen Info and Help tabs

That brings us back to the original problem - does "Post Settings" still make sense when a block's advanced properties are showing?

@jasmussen
Copy link
Contributor

That brings us back to the original problem - does "Post Settings" still make sense when a block's advanced properties are showing?

I think it does. The blocks are part of your post, so it makes sense that post settings hold block settings also. I understand that we are discussing semantics here, and like I said I'm okay with finding a new name — I'm not necessarily arguing for "Post Settings" and "Page Settings" and "[CPT] Settings" as the best name. I just don't feel like we've found any alternatives that are universally better. "Settings" is perhaps fine too, but "Inspector", as much as I love both the concept and the feature, seems too techy.

@youknowriad
Copy link
Contributor

Just an idea, I'm not sure it's worth it but Maybe we should drop the label in favour of an arrow icon (open/close sidebar)

@GaryJones
Copy link
Member Author

Maybe we should drop the label in favour of an arrow icon

Screen reader users will still need some verbal clue what it relates to, and new users need to be able to reference it in their questions.

@GaryJones
Copy link
Member Author

My argument of a better button title is one of theoretical purity, but that should always be trumped by catering to what users need first.

I'm in agreement with @jasmussen's viewpoint - "Post Settings" et al may not be perfect, but I'm struggling to think of a better one that conveys exactly what we mean, for everyone.

As the OP, I'm closing this one out. This can at least act is the discussion that I originally couldn't find. Feel free to make further suggestions, that account for the above viewpoints.

@jasmussen
Copy link
Contributor

This was a good discussion, thank you. It's good to have this avenue explored, and as we continue to work on this we can revisit if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants