Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple empty blocks create visual noise and make hard to edit a post #13599

Closed
folletto opened this issue Jan 30, 2019 · 9 comments · Fixed by #28275
Closed

Multiple empty blocks create visual noise and make hard to edit a post #13599

folletto opened this issue Jan 30, 2019 · 9 comments · Fixed by #28275
Assignees
Labels
[Block] Paragraph Affects the Paragraph Block Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@folletto
Copy link
Contributor

screenshot 2019-01-30 at 14 43 26

Multiple empty blocks add extensive visual noise to the interface.

I understand they are there for a reason and we discussed this before, bu I'm wondering if we can find a better way to handle these scenarios.

Brainstorming possible ideas:

  1. Show the text only on the first block of a type that gets added.
  2. Show the text only when the post is empty and created for the first time.
  3. Show the text only for the first three blocks, then stop.
  4. Show the text only for the first 1 minute, then stop.
  5. Show the text only until the person uses any block inserter for the first time (as it's a signal they understood how it works).

Sidenote

This might also be related with the behaviour of stripping empty spaces when rendering — which is currently circumventable by adding a single space in an empty block (good workaround, still a workaround).

@swissspidy swissspidy added Needs Design Feedback Needs general design feedback. [Block] Paragraph Affects the Paragraph Block labels Feb 7, 2019
@kjellr
Copy link
Contributor

kjellr commented Feb 7, 2019

I opened a related issue a while back that proposed a different solution: Keep the paragraph block's placeholder text as is, but show it on hover + select:

More details here: #10051

@sarahmonster
Copy link
Member

@kjellr's solution seems like a good approach here in terms of both reducing unneccesary noise and bringing the unselected block appearance into closer alignment with the actual front-end output of the site.

@mapk
Copy link
Contributor

mapk commented Jun 21, 2019

I agree with Kjell's solution as well. I'm removing the "Needs Design Feedback" label.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jun 21, 2019
@towfiqi
Copy link

towfiqi commented Mar 1, 2020

Whats even worse is, you cannot remove them right away. You have to click and type something first on each of them to make the toolbar appear and then select the remove option.

@mapk
Copy link
Contributor

mapk commented Mar 6, 2020

I came across another solution, I think implemented by @phpbits.

When hitting enter multiple times (ie. 3 times) the interface asks you if you'd like to convert these to a Spacer block. If a setting exists that automatically makes this change every time for you, that would be wonderful.

@phpbits
Copy link
Contributor

phpbits commented Mar 7, 2020

I've implemented the work around via EditorsKit plugin. Here's the preview : https://twitter.com/phpbits/status/1181065985123446784 . Thanks!

@folletto
Copy link
Contributor Author

folletto commented Mar 9, 2020

While I like that idea, and I'd +1 the inclusion, I don't think it's really solving the issue mentioned, just making it a bit less visible.

So +1 to that, and let's still find a solution for the duplication. Showing the text only when the block is active it would help :)

@mapk
Copy link
Contributor

mapk commented Apr 14, 2020

Good point. When I click Enter multiple times in Google Docs, I don't see placeholder text, and this feels like I should have a similar experience.

@mapk
Copy link
Contributor

mapk commented Apr 14, 2020

related: #17366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
8 participants