Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the modal title styling consistent #13650

Closed
afercia opened this issue Feb 4, 2019 · 1 comment · Fixed by #13669
Closed

Make the modal title styling consistent #13650

afercia opened this issue Feb 4, 2019 · 1 comment · Fixed by #13669
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Feb 4, 2019

The modal title has the following default styling:

screenshot 2019-02-04 at 09 28 36

The keyboard shortcut modal wraps the title in a <span> element, which is then styled with a bigger font size and bold font weight:

screenshot 2019-02-04 at 09 29 20

const title = (
<span className="edit-post-keyboard-shortcut-help__title">
{ __( 'Keyboard Shortcuts' ) }
</span>

If the styling with the bigger font size and bold font weight is preferred, I'd suggest to make it the default in the Modal component instead of overriding it on a case by case basis. This way, all the modals (even the ones added by plugins) will have the same styling.

@afercia afercia added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Feb 4, 2019
@kjellr
Copy link
Contributor

kjellr commented Feb 4, 2019

Agreed, the larger font size and bold text seem reasonable to use in all modals by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants