Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Block - Cannot update after deleting last empty list item #13864

Closed
JavonDavis opened this issue Feb 13, 2019 · 8 comments
Closed

List Block - Cannot update after deleting last empty list item #13864

JavonDavis opened this issue Feb 13, 2019 · 8 comments
Labels
[Block] List Affects the List Block Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@JavonDavis
Copy link

Describe the bug
Before or after publishing a blog post with a list that has the last item being empty, simply removing that item does not autosave, update in preview or allow the user to press the update button or update the post in preview.

To Reproduce
Steps to reproduce the behavior:

  1. Create a list block with the last item being empty
  2. Either save, publish or preview
  3. Remove empty list item
  4. Update the post or preview
  5. Should still see the empty list item

Expected behavior
Empty list item should be removed

Screenshots
screen shot 2019-02-13 at 11 36 37 am

screen shot 2019-02-13 at 11 36 50 am

Desktop:

  • OS: MacOS Mojave 10.14.2
  • Browser: Chrome
  • Version: 72

Additional context

  • Gutenberg editor from a .com site
@youknowriad
Copy link
Contributor

I'm pretty sure this is fixed by #13697 but needs testing cc @iseulde

@youknowriad
Copy link
Contributor

Yes, this seems fixed for me in master.

@ellatrix
Copy link
Member

😄😄😄

@JavonDavis
Copy link
Author

Thanks @youknowriad!

@arunsathiya
Copy link
Contributor

I am afraid this is still reproducible. I just tested on master branch, and as @JavonDavis noted, the update button is not clickable on removing the last empty list item.

Likewise, clicking outside the block (to make the update button clickable), and clicking on it does not seem to remove the empty list item. On the preview/live view, the empty list item can be noted to be visible.

Tested on Google Chrome Version 72.0.3626.109 (Official Build) (64-bit) with macOS 10.14.2 - Mac OS Mojave. Here is a video of the entire process.

@youknowriad
Copy link
Contributor

Reopening for further investigation

@swissspidy swissspidy added Needs Testing Needs further testing to be confirmed. [Block] List Affects the List Block labels Mar 26, 2019
@ellatrix
Copy link
Member

ellatrix commented Apr 2, 2019

I cannot reproduce this issue, also not after doing the steps in the video.

@oxyc
Copy link
Member

oxyc commented Jun 20, 2020

Also tested this and cannot reproduce. Are you sure you were using the plugins master branch @arunsathiya? there's supposed to be a Gutenberg menu item in the side menu when the plugin is active but you don't have it in your video (although I'm not 100% how long it's been there).

@oxyc oxyc added the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

6 participants