Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom block styles cause a crash for nested block containers #13893

Closed
kjellr opened this issue Feb 15, 2019 · 2 comments
Closed

Custom block styles cause a crash for nested block containers #13893

kjellr opened this issue Feb 15, 2019 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Feb 15, 2019

Describe the bug

Assigning a custom block style to a nested block container (like the Media & Text or Columns block), causes a crash when you attempt to open the styles panel.

To Reproduce

  1. Register a custom block style, targeting core/media-text or core/columns
  2. In the editor, select the type of block you attempted to style.
  3. Attempt to open the block switcher, and observe the crash.
  4. In the sidebar, attempt to open the "Styles" panel and observe the crash.

Expected behavior

These should be able to accept block styles just like any other block.

Screenshots

media-text

screen shot 2019-02-15 at 8 52 28 am
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P labels Feb 15, 2019
@kjellr
Copy link
Contributor Author

kjellr commented Feb 15, 2019

It'd be great to get this sorted out before #13822 is merged in, otherwise I imagine any block styles for the cover image block will trigger crashes as well.

@kjellr kjellr added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Feb 15, 2019
@kjellr
Copy link
Contributor Author

kjellr commented Feb 15, 2019

Looks like this has already been filed here: #9897

Closing this as a duplicate.

@kjellr kjellr closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjellr