Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in new tab" link setting shows incorrectly when editing multiple links #13950

Closed
kriskarkoski opened this issue Feb 19, 2019 · 1 comment
Labels
[Package] Format library /packages/format-library [Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended

Comments

@kriskarkoski
Copy link

Describe the bug
Editing multiple "Open in new tab" link settings sometimes results in the state being shown incorrectly on refresh.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new draft at /wp-admin/post.php and add at least two links
  2. Enable "Open in new tab" on multiple links
  3. Save the draft and refresh
  4. Edit one of the links to turn off "Open in new tab"
  5. Save draft and refresh
  6. Edit the link that should still have "Open in new tab" enabled and note the state indicates it is disabled. Edit the other link, which should correctly show as disabled, then return to the link that should be enabled and the state will correctly show it enabled again.

This can be reproduced both within one draft and when changing this across multiple drafts.

Expected behavior
Editing this setting on one link should not affect other links.

Screenshots
gutenberg new tab lost

Desktop (please complete the following information):

  • OS: Mac OSX 10
  • Browser: Chrome
  • Version: Chrome 72.0.3626.109

Additional context

  • WordPress 5.0.3
@jorgefilipecosta jorgefilipecosta added [Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Feb 19, 2019
@ellatrix ellatrix added [Package] Format library /packages/format-library and removed [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Feb 20, 2019
@youknowriad
Copy link
Contributor

I'm not able to reproduce this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Format library /packages/format-library [Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants