Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation manifest to use relative links instead of pointing to "master" explicitely. #14303

Closed
youknowriad opened this issue Mar 7, 2019 · 4 comments
Labels
[Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.

Comments

@youknowriad
Copy link
Contributor

This will allow building the handbook from several branches.

cc @chrisvanpatten @mkaz @nosolosw

@youknowriad youknowriad added [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement. labels Mar 7, 2019
@oandregal
Copy link
Member

Core ticket: https://meta.trac.wordpress.org/ticket/4244

@oandregal
Copy link
Member

@youknowriad was looking into this today. I saw the core patch to update the branch the contents are pulled from in the plugin.

I'm offering a different approach here that doesn't require adding steps to the WordPress release process:

  • PHP docs importer will stay as it is. No changes necessary during WordPress releases.
  • Manifest markdown_source entries are updated after the WordPress release to point to the latest stable branch. Example: Pin branch used to build handbook #14699

@oandregal
Copy link
Member

PR ready at #14739

@oandregal
Copy link
Member

Closing this as the DevHub's handbook uses relative links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants