-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media & Text: Improve resizing #14410
Comments
Definitely — this is a great idea. Let's make sure to use the popover component when building it.
I think this would help a lot. Especially if we take inspiration from the above, and combine that extra space within the hit target: What if the drag bar also snapped to increments of 5%? |
definitely!
#14481 already adds the big invisible handles for all sides for usability purposes. In a separate PR, I will experiment with your draft that adds the visible part - the blue line. I'll ping you there once I have something. |
Awesome 👍 |
I had a vertical image and when I placed it it was made larger. I wanted a way to set the image as 100% size with no scaling and could not work it out. I also found no way to align the text block to the top. Since it looked ugly I settled for a regular paragraph and image stacked on top of each other. Look at the MailChimp version of my newsletter: https://mailchi.mp/9af650b6eb36/meeting-schedule-assistant-version-1909-is-now-available I was able to set the image nicely. In Wordpress: https://www.publictalksoftware.co.uk/2019/04/01/meeting-schedule-assistant-v19-0-9-newsletter/ I had to stack. There is no way to tell it what scale to put the image in. Whilst you can scale columns you can't scale images. |
This should be all set since #14543 got merged. @ajtruckle If you're still having issues, would you mind opening a new issue for it? Thanks, all! |
Is your feature request related to a problem? Please describe.
Media & Text block can be resized to a different ratio of media and text. It's done using a tiny blue dot that shows when the Media & Text block is focused directly (ignores focus of child blocks) and at the same time, some media has to be selected (resizer doesn't show up together with media placeholder).
When adding this block, focus is automatically in child paragraph and no media is obviously selected. That means the dot might be missed by a lot of people - I've seen several coworkers of mine who were surprised about this feature despite working with Gutenberg for some time.
When using the resizer, the percentage value you are sliding to it not obvious - not during the resizing, not after. Imagine trying to build a landing page where you need to use 60% text, 40% image for multiple different blocks. You can only approximate in the visual mode or edit the number in code directly. You might not even know if the value is a whole number or if it is a float with some higher precision.
Describe the solution you'd like
I think the solution might consist of several small improvements that we can ship individually. A few of my ideas:
Those are a few points that were on my mind to improve the resizing workflow for Media & Text and I wanted to open a discussion about it and whether we might come up with other areas to improve.
The text was updated successfully, but these errors were encountered: