Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block mover controls hidden on full-width block #14817

Closed
dianeco opened this issue Apr 4, 2019 · 3 comments · Fixed by #15022
Closed

Block mover controls hidden on full-width block #14817

dianeco opened this issue Apr 4, 2019 · 3 comments · Fixed by #15022
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@dianeco
Copy link

dianeco commented Apr 4, 2019

Describe the bug
The block mover controls are hidden for all full-width blocks making impossible to move them.
This regression appears at least since Gutenberg 5.3 and therefore is in WordPress 5.2 Beta 1.

@m-e-h
Copy link
Member

m-e-h commented Apr 9, 2019

Looks like the HTML changed at some point?
In addition to the full-width movers being hidden behind the admin-sidebar, the align-wide movers are now vertical and on the side instead of horizontal above the block like they once were.

The CSS selector for full width is:

.editor-block-list__layout .editor-block-list__block[data-align="full"] > .editor-block-mover

I haven't check but I'm guessing it's still there.

It's missing the target now because .editor-block-mover isn't a direct descendent of [data-align="full"] or [data-align="wide"] anymore. It's wrapped in block-editor-block-list__block-edit now.

If the current HTML is correct than the CSS selector needs changed to something like this:

.editor-block-list__layout .editor-block-list__block[data-align="full"] > .block-editor-block-list__block-edit > .block-editor-block-mover

Is this HTML change legit? Should the CSS be adjusted? @kjellr @youknowriad

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Apr 17, 2019
@aduth aduth added the [Type] Regression Related to a regression in the latest release label Apr 17, 2019
@aduth
Copy link
Member

aduth commented Apr 17, 2019

Appears related: #12758 (cc @jasmussen, @gziolo )

@aduth
Copy link
Member

aduth commented Apr 17, 2019

Fix pull request: #15022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants