-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media & Text block: Option to link media. #15422
Comments
I've encountered this a few times. It's a common use case to want to link that image, and the only way possible right now is to use HTML. It would be great to see the link option added! |
So what we need right now is a dev that is able to add the image link icon to the toolbar. Perhaps this is something that Andrei can take a look at? Or someone else. |
I guess here the main concern is that the block is Media + Text, not Image + Text. Video files are not usually linked and I feel as if folk use this block "improperly", instead of using a floated image block and a heading. I'll label it accordingly and wait it out :) |
We could have the Link Settings panel only available if |
I've created a solution for this issue few weeks ago on EditorsKit plugin : https://wordpress.org/plugins/block-options/ . Here's how it works : My implementation is using the similar existing way of adding link on Image Block. Then added few link options for "rel" attributes. The link toolbar will only be available when media type is |
@phpbits that feels pretty good. @draganescu what do you think about just showing the link option for images as in the EditorsKit plugin? ... without all the extra link options though... |
@mapk Thanks! I've spiced up the Media and Text Block a bit last few weeks. I've also added the card-like layout aside from left and right image position ;) Edited: Please make sure to check this issue as well : #17556 . I believe the images will be linked to sponsored urls as well. So this is related. Thanks! |
Yes, I think we're set, will assign this to me and take a stab at it. ( cc @mapk ) |
@mapk should we also include the Media File and Attachment options that the image block's link control provides? |
This is now testable in #18139 |
Having a similar issue as described at the start of this post. Is this feature out of testing and live on Wordpress.org/.com? Would love to be able to use it! |
Howdy @Clearly5000 it is almost ready, goign through reviews right now, it will be testable as soon as #18139 gets merged in master. |
Great news, thanks! |
i used media and text block ....and i want to edit the image through html want to add more images with a class ewhich i will use for js ...but i cant find the edit as html option...plus how one can achieve this with media and text block |
Hi! @MAHNOORKHANDURRANI Your question seems more fit in the WordPress developer forum |
Is your feature request related to a problem? Please describe.
It would be nice to be able to link the media in the Media & Text block. Similar to the single image block.
Existing Media & Text block:
Single image block:
Describe the solution you'd like
A standard single image linking method added to the block.
Describe alternatives you've considered
Well one could probably go in through HTML and add a link but that is not very intuitive.
Btw we need a consistent way to handle images in all blocks.
The text was updated successfully, but these errors were encountered: