Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the usage of react-click-outside from the Modal component #15790

Closed
youknowriad opened this issue May 23, 2019 · 1 comment
Closed

Remove the usage of react-click-outside from the Modal component #15790

youknowriad opened this issue May 23, 2019 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

That dependency still relies on deprecated React features (findDOMNode) and we have a better built-in alternative (See #14851).
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels May 23, 2019
@youknowriad youknowriad mentioned this issue May 23, 2019
Closed
12 tasks
@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 23, 2019
@aduth aduth mentioned this issue May 23, 2019
Open
@gziolo
Copy link
Member

gziolo commented Oct 20, 2019

It uses now:

gutenberg/packages/components/src/modal/frame.js

Line 19 in ba4793b

import withFocusOutside from '../higher-order/with-focus-outside';

Resolved in #16878.

@gziolo gziolo closed this as completed Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowriad @gziolo