Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg is broken on IE since react-spring was introduced #16194

Closed
tellthemachines opened this issue Jun 17, 2019 · 1 comment · Fixed by #16196
Closed

Gutenberg is broken on IE since react-spring was introduced #16194

tellthemachines opened this issue Jun 17, 2019 · 1 comment · Fixed by #16196
Assignees
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@tellthemachines
Copy link
Contributor

tellthemachines commented Jun 17, 2019

Describe the bug

Navigating to the post editor in IE11 results in a blank page. Dev tools console shows multiple JS syntax errors.

To reproduce

Steps to reproduce the behavior:

  1. Check out the master branch
  2. On IE, in wp-admin, navigate to "new post" or any or edit any existing post.
  3. Verify blank page results, open console and check errors (you may need to reload the page for all console errors to display)

Expected behavior

Post editor should work correctly in IE

Desktop (please complete the following information):

  • OS: Windows 7, WIndows 10
  • Browser: Internet Explorer
  • Version: 11 (latest)

Additional context

There's a related issue in react-spring repo that outlines a solution: pmndrs/react-spring#552 (comment)
I have tested that fix on my local and it works; IE displays correctly after modifying webpack config and rebuilding.

@tellthemachines tellthemachines added the [Type] Bug An existing feature does not function as intended label Jun 17, 2019
@talldan talldan added the Browser Issues Issues or PRs that are related to browser specific problems label Jun 17, 2019
@swissspidy swissspidy added the [Priority] High Used to indicate top priority items that need quick attention label Jun 17, 2019
@talldan
Copy link
Contributor

talldan commented Jun 17, 2019

Tested version 5.9.2 of the plugin on IE11 and confirm the error is present in the published plugin as well.

Looks like react-spring was introduced in 5.9 in #15908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants