Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Block and Multiple Buttons #16480

Closed
mtias opened this issue Jul 9, 2019 · 3 comments · Fixed by #17352
Closed

Button Block and Multiple Buttons #16480

mtias opened this issue Jul 9, 2019 · 3 comments · Fixed by #17352
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Jul 9, 2019

One fairly common need is aligning more than one button in a row. Multiple block libraries have added similar tools (either a special multiple buttons block or the ability to add more instances in a single button block). We should explore bring this into core, likely leveraging child blocks for the extra buttons, but in a more convenient way than forcing people to add columns first to hold each button in place.

@jasmussen
Copy link
Contributor

YO! I passionately love this ticket, so I created a mockup:

buttons

The mockup above is inspired by efforts underway in #16897 (comment), where we are building a container for social links that show up side by side.

This would work the same for a Button Group or what the name might end up as.

As noted in that ticket referenced, this would make use of a new UI feature we'd build for parent block containers, to allow child block UIs to be absorbed by the parent.

@mtias
Copy link
Member Author

mtias commented Aug 23, 2019

This would work the same for a Button Group or what the name might end up as.

I hope we can call this just "Buttons". Another thing that this should also help with is that alignment controls move from the individual "Button" block (what we have right now) to the container "Buttons".

@ZebulanStanphill
Copy link
Member

What if the Group block had a horizontal layout option? Using flexbox you could have a wide range of alignment/spacing controls, and you could use show several blocks (not just buttons) on the same line without having to use columns. (And with flex-wrap it would be easily responsive.)

@jorgefilipecosta jorgefilipecosta self-assigned this Sep 5, 2019
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants