Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Button Block Styles #16481

Closed
mtias opened this issue Jul 9, 2019 · 5 comments · Fixed by #17253
Closed

Simplify Button Block Styles #16481

mtias opened this issue Jul 9, 2019 · 5 comments · Fixed by #17253
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Jul 9, 2019

We should revise the style variations we are offering for the button block as we have created a matrix of outline/fill rounded/squared that is not the most elegant or usable. ("How can I get a squared and outlined button?")

I'd suggest removing the square/round pairs from the style selection and turning that into a border radius setting instead. That'd allow us to keep just two style variations (fill / outline).

@mtias mtias added the [Block] Buttons Affects the Buttons Block label Jul 9, 2019
@truchot
Copy link
Contributor

truchot commented Jul 10, 2019

I agree with @mtias!

If default button is already styled (by theme most overtime) with no radius the squared style is useless.

@benoitchantre
Copy link
Contributor

Great idea.

Is it really necessary to add a border radius setting?
I think it is better for consistency if the style radius comes from CSS.

@mapk
Copy link
Contributor

mapk commented Jul 24, 2019

Would the border-radius setting be per block? I ask because changing the border-radius of buttons is probably something that makes more sense in the global settings arena which we don't really have yet.

Maybe getting this setting into the Button block is a good version 1. I'd love to see this expand into a global setting in the future as those are explored more.

@mtias
Copy link
Member Author

mtias commented Jul 26, 2019

I ask because changing the border-radius of buttons is probably something that makes more sense in the global settings arena which we don't really have yet.

This is a good point, but also applies to style variations in general. We've discussed allowing setting certain attributes as defaults for any new block, and some of that is covered in #7551

@klihelp
Copy link

klihelp commented Aug 14, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants