Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify text alignment location between Heading and Paragraph blocks #16648

Closed
mapk opened this issue Jul 17, 2019 · 2 comments · Fixed by #17419
Closed

Unify text alignment location between Heading and Paragraph blocks #16648

mapk opened this issue Jul 17, 2019 · 2 comments · Fixed by #17419
Labels
[Block] Heading Affects the Headings Block [Block] Paragraph Affects the Paragraph Block

Comments

@mapk
Copy link
Contributor

mapk commented Jul 17, 2019

The text alignment for a Paragraph block is located right in the toolbar. When making a text alignment change to a Heading, I expected it to be located similarly in the toolbar as well.

Can we unify the placement of the alignment options? Maybe we can move the text alignment options for the Heading block to the block's toolbar as well?

Screenshots

text-alignment

@mapk mapk added Needs Design Feedback Needs general design feedback. [Block] Heading Affects the Headings Block [Block] Paragraph Affects the Paragraph Block labels Jul 17, 2019
@karmatosed
Copy link
Member

Ah alignment, this has gone back and forth :) I think to make it consistent works so for me, that's the baseline here.

@kjellr
Copy link
Contributor

kjellr commented Jul 23, 2019

Yes — It's very weird to have this in the sidebar but not in the toolbar. No other blocks do that, so we should make it consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Block] Paragraph Affects the Paragraph Block
Projects
None yet
3 participants