Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to document for different platforms #17230

Closed
oandregal opened this issue Aug 28, 2019 · 2 comments
Closed

How to document for different platforms #17230

oandregal opened this issue Aug 28, 2019 · 2 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Tool] Docgen /packages/docgen [Type] Enhancement A suggestion for improvement.

Comments

@oandregal
Copy link
Member

oandregal commented Aug 28, 2019

We're increasing the code we share between mobile and web, so we need to figure out ways to automatically document what belongs to each platform.

Reference: (core-js slack conversation).

  • In consolidating some components to work for on web and mobile (ReactDOM and React Native) we have the need to mark some props to belong only in a specific platform (example, className is another web-only prop).
  • We also likely need to mark some to work on Android or iOS.
  • There might be props that are required in one platform but not in another. Pending use case.
  • Event handlers are a bit more nuanced. We're aiming to have the same API, but some cases may need to be declared per-platform (for ex: onError).

Some examples:

@oandregal oandregal added [Tool] Docgen /packages/docgen [Type] Developer Documentation Documentation for developers labels Aug 28, 2019
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 4, 2019
@hypest
Copy link
Contributor

hypest commented Aug 11, 2020

FYI, added this to the "Mobile Apps" project board to cover the apps side of the issue.

@ryanwelcher ryanwelcher removed the [Type] Developer Documentation Documentation for developers label Feb 28, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
@oandregal
Copy link
Member Author

docgen has been in use for a few years now and this hasn't been an issue. We can reopen if it becomes one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Tool] Docgen /packages/docgen [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

5 participants