Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Menu should not show an appender on single root items #18104

Closed
mtias opened this issue Oct 25, 2019 · 0 comments · Fixed by #18153
Closed

Navigation Menu should not show an appender on single root items #18104

mtias opened this issue Oct 25, 2019 · 0 comments · Fixed by #18153
Assignees
@tellthemachines
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Oct 25, 2019

Top level items shouldn't show an appender for creating sub-menus on selection.

image

Instead, to create a sub-menu there should be a toolbar item:

62833108-709ce900-bc39-11e9-9b81-eb49dc358f20

It's fine to show the trailing appender if there are already sub-menu items within a top level item.
@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Navigation Affects the Navigation Block labels Oct 25, 2019
@mtias mtias mentioned this issue Oct 25, 2019
Merged
5 tasks
@jasmussen jasmussen mentioned this issue Oct 27, 2019
Merged
9 tasks
@tellthemachines tellthemachines mentioned this issue Oct 29, 2019
Merged
5 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tellthemachines tellthemachines

Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show appender only when item has submenu WordPress/gutenberg
3 participants
@draganescu @mtias @tellthemachines