Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Size Picker: disableCustomFontSizes doesn't remove Custom option from the select box #18212

Closed
gziolo opened this issue Oct 31, 2019 · 1 comment
Closed

Font Size Picker: disableCustomFontSizes doesn't remove Custom option from the select box #18212

gziolo opened this issue Oct 31, 2019 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Oct 31, 2019 •
edited
Loading

Describe the bug
Originally reported in #18149:

The example which has the custom sizes disabled works only partially, since, in the dropdown, there is still
an option labeled Custom:
Screen Shot 2019-10-31 at 10 40 33

To reproduce
Steps to reproduce the behavior:

  1. Run Storybook: npm run design-system:dev or open https://wordpress.github.io/gutenberg/design-system/components/.
  2. Go to the FontSizePicker section.
  3. Pick the one named Without Custom Sizes
  4. Check the select box.

Expected behavior
There is no Custom option when disableCustomFontSizes flag is passed to FontSizePicker component.

Desktop (please complete the following information):

  • OS: macOS
  • Browser Chrome
  • Version 77
@gziolo gziolo added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components labels Oct 31, 2019
@gziolo gziolo mentioned this issue Oct 31, 2019
Merged
@gziolo gziolo added Needs Dev Ready for, and needs developer efforts Storybook Storybook and its stories for components labels Oct 31, 2019
@brentswisher
Copy link
Contributor

Thanks for filling these followups, this one was already reported in #17941 and has a fix in progress in PR #18049 so I'm going to close this one.

@gziolo gziolo mentioned this issue Oct 31, 2019
Closed
@gziolo gziolo added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gziolo @brentswisher