Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select groups or columns since 7.1 update #19076

Closed
joshm33333 opened this issue Dec 11, 2019 · 3 comments
Closed

Can't select groups or columns since 7.1 update #19076

joshm33333 opened this issue Dec 11, 2019 · 3 comments

Comments

@joshm33333
Copy link

joshm33333 commented Dec 11, 2019

Describe the bug
Since updating to 7.1 the slight padding around the child objects is gone and selecting is impossible. This applies to the core/columns and core/group blocks. I've disabled my theme to verify it's native to Gutenberg, and also tested on multiple sites.

I've tried using CSS to add padding with no luck. I found that if clicking on the psuedo element works for columns works, but it is not visible and very difficuly to find. Adding this CSS helped as a temporary solution (just adding this to help convey the problem):
[data-type="core/columns"]:before{border:1px solid;}
No such luck for groups.

Ultimately downgraded to Gutenberg 7 because this issue makes Gutenberg unusable for me. Verified 7.0 still works fine. Will be watching this thread because I really want that drag-and-drop featured images feature.

To reproduce
Steps to reproduce the behavior:
Just create a group with a heading inside, and try to select the group.

Expected behavior
There used to be a cursor:pointer and a hover effect, those are both gone now. Clicking should select the parent element.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Edge Beta
  • Version: Gutenberg 7.1
@ZebulanStanphill
Copy link
Member

You can select parent blocks using any of the following 3 methods:

  1. The breadcrumb bar at the bottom of the screen.
    image

  2. The select tool, which selects parent blocks on first click, then children on second click, then children-of-children on third click, etc. Clicking the deepest child re-enters the standard edit mode, as does clicking the block title or pressing Enter.
    image

(Ignore the template library button in the screenshot; that's added by a plugin.)

  1. The Block navigation menu.
    image

@joshm33333
Copy link
Author

Didn’t know any of that
Is what I found actually a bug then? Or is this expected behaviour?

@ZebulanStanphill
Copy link
Member

@joshm33333 It's expected behavior. One of the main pull requests involved is #18105, where you can see some of the reasoning for the change. This is the latest in a long series of iterations trying to improve the experience with nested blocks. The select tool was introduced partially because it was decided that trying to select specific blocks would need its own mode/tool in order to be as easy as possible without interfering with standard editing.

I think perhaps the select tool should be mentioned somewhere in the editor's welcome guide, but that belongs in a separate issue. Feel free to open a new issue suggesting that or other ways to make it more clear how to select parent blocks easier.

Notably, there should be a 4th way to select parent blocks: pressing the up arrow key on your keyboard. This worked in 7.0.0 but has since been broken somehow. I've already reported this regression: #18928.

As a side note, there is also an open issue (#10524) and pull request (#15830) for adding an option be added to show visible toolbar labels in the top toolbar. That could make discovery of the select tool feature easier.

There is also a PR (#19034) that changes the style of the breadcrumb bar links in an attempt to make it more obvious that they are clickable. Feel free to leave feedback there on what you think of the proposed changes there.

Anyway, I'm closing this issue since technically there's no bug here, but feel free to open new issues suggesting ways to further improve the interface, or leave a comment on existing issues/PRs if you have any relevant thoughts/ideas you want to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants