Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Navigation doesn't display contents of a Reusable Block #19372

Closed
0aveRyan opened this issue Dec 31, 2019 · 6 comments · Fixed by #27887
Closed

Block Navigation doesn't display contents of a Reusable Block #19372

0aveRyan opened this issue Dec 31, 2019 · 6 comments · Fixed by #27887
Labels
[Block] Block The "Reusable Block" Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@0aveRyan
Copy link
Contributor

Describe the bug
The blocks contained inside a Reusable Block aren't shown in the Block Navigation in a sub-tree similar to how other parent blocks such as Columns show the blocks they contain.

To reproduce
Steps to reproduce the behavior:

  1. Insert multiple blocks in the Block Editor.
  2. Highlight multiple blocks and select Convert to Reusable Block.
  3. Name and Save the Reusable Block.
  4. Open the Block Navigation from the Editor Toolbar and only Reusable Block is shown, not the contained blocks as a sub-tree.

Expected behavior
The Block Navigation should ideally reveal the contents of a Reusable Block in a sub-tree similar to how Columns, Groups, Media & Text and other blocks that contain children display a sub-tree when highlighted.

Additional context

  • WordPress: Version 5.3.3-alpha-46995
@0aveRyan 0aveRyan added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Block The "Reusable Block" Block labels Dec 31, 2019
@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Apr 21, 2020
@noisysocks
Copy link
Member

This isn't expected functionality as the Reusable Block is a block which has an entirely different block editor in it, not a block with child blocks. Agree that it would be a nice enhancement, though.

@0aveRyan
Copy link
Contributor Author

@noisysocks I'm aware it's using BlockEditorProvider, separate data storage, underlying code, etc.

I disagree it's not expected behavior -- to an end user the UX is just another block containing child blocks. The user doesn't know it's an entirely different Block Editor. It's the DX that's entirely different.

I'm happy to explore a PR for this.

@0aveRyan
Copy link
Contributor Author

0aveRyan commented May 5, 2020

I'll be working on a PR to explore this later this week. At the same time I'll be looking to address block breadcrumbs in the footer for consistency.

EDIT: I've needed to step back from this and other Core/Gutenberg work for the foreseeable future. Someone else is welcome to pick up this ticket.

@helpdata
Copy link

helpdata commented Jun 18, 2020

This is surely a bug. I have a reusable block that consists merely of one container with a few containers in that, and I now cannot navigate within that structure since the Block Navigation does not show it, just shows "reusable block", even the block has been opened to "edit".

I mean, I get that there is a separate editor for these blocks, but then why let people edit them in situ when it does not work ... unless you just want to add some text or some trivial change. Anything more than that, you're lost.

@Ugoku
Copy link

Ugoku commented Jul 3, 2020

Adding my experience to this bug:
I have a group, made up of two columns with content that I made into a reusable block. Now, there appears to be no way to change the classes of the block or to select the columns. Having the blocks inside a reusable block in the navigation tree would be very beneficial.

-edit-
I just came across this plugin: https://wordpress.org/plugins/fabrica-reusable-block-instances/ which is a big help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Block The "Reusable Block" Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants