Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Block: Post Excerpt #19698

Closed
mapk opened this issue Jan 16, 2020 · 8 comments · Fixed by #19715
Closed

New Block: Post Excerpt #19698

mapk opened this issue Jan 16, 2020 · 8 comments · Fixed by #19715
Assignees
Labels
Customization Issues related to Phase 2: Customization efforts Needs Design Feedback Needs general design feedback. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@mapk
Copy link
Contributor

mapk commented Jan 16, 2020

As indicated in #15623, there will be a suite of Post blocks that make up the Post template.

This is the Post Excerpt block.

Features

  • Allow editing of the word count.
  • Allow direct editing of the "Read more" link.

Mockups

Selected (grays out the uneditable text)

Screen Shot 2020-01-15 at 8 20 33 PM

Unselected (text resumes normal color)

Screen Shot 2020-01-15 at 8 20 42 PM

Questions

  • Should we show a placeholder screen that allows the selection of a particular post, category, or tag?
  • Should this block inherit a parent block's settings like category type, or tag?
@mapk mapk added Customization Issues related to Phase 2: Customization efforts New Block Suggestion for a new block labels Jan 16, 2020
@mapk
Copy link
Contributor Author

mapk commented Jan 16, 2020

A placeholder screen might make sense if this block is ever used on it's own, but if it was the child block of a Posts template, I'd assume it would be repeated and that it would inherit the parent block's setting for a specific category, tag, or something like "recent."

Here's a quick mockup that doesn't take all this into account, but gets the point across.

Screen Shot 2020-01-15 at 8 20 54 PM

@epiqueras
Copy link
Contributor

This block should never manage its own post context. It will just inherit it from a parent Post block or the top-level post context.

Should this block inherit a parent block's settings like category type, or tag?

I don't see how category type or tag is a setting of the post excerpt.

@mapk mapk added the Needs Design Feedback Needs general design feedback. label Jan 16, 2020
@mapk
Copy link
Contributor Author

mapk commented Jan 16, 2020

I don't see how category type or tag is a setting of the post excerpt.

I imagined if I was creating a Category page, listing excerpts of all posts with that category, then I'd want my post excerpts reflect that from the parent or CPT, right? Maybe I'm thinking about this incorrectly?

@epiqueras
Copy link
Contributor

This is a Post Excerpt block, not a Post Excerpts block. The category page would wrap this in a query block that renders multiple instances of it, each with a different post context.

@paaljoachim
Copy link
Contributor

Would this be the block to also adjust the words "Read more.." or something else the user decides?
Example the user would like to instead use the words "Continue reading".

@epiqueras
Copy link
Contributor

Yes

Allow direct editing of the "Read more" link.

@richtabor
Copy link
Member

richtabor commented Jan 24, 2020

Is there any objection to using a RangeControl with a value entry field for "word count"? Seems it may be a similar solution than the proposed control.

I'm not sure how valuable multiple pre-determined count variations would be - as the user would likely manipulate the count based on the font size/content width/theme style (and how those look work together).

And what do we think about adding fontSize capability, like the Paragraph block (as these are paragraphs)?

@epiqueras
Copy link
Contributor

Is there any objection to using a RangeControl with a value entry field for "word count"?

That's what I did.

I'm not sure how valuable multiple pre-determined count variations would be - as the user would likely manipulate the count based on the font size/content width/theme style (and how those look work together).

Agreed.

And what do we think about adding fontSize capability, like the Paragraph block (as these are paragraphs)?

Makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization Issues related to Phase 2: Customization efforts Needs Design Feedback Needs general design feedback. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants