Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Nineteen misalignment on editor #20067

Closed
karmatosed opened this issue Feb 6, 2020 · 4 comments
Closed

Twenty Nineteen misalignment on editor #20067

karmatosed opened this issue Feb 6, 2020 · 4 comments
Labels
Needs Testing Needs further testing to be confirmed. [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

I note I am only seeing this in Twenty Nineteen but it might also be a problem in other themes. I did explore all the "Twenties" and a few others to try and find if it was to do with editor styles. Props to @jasmussen for the idea to explore that.

I see the following in Chrome and Safari:

twentynineteen

I tested on branch today with a recent install/run to make sure up to date. I am marking this as high in case this is a situation needs fixing for 5.4 and looping in @mapk and @jorgefilipecosta. I know a few have seen this infrequently before but it now seems constant.

A little note, if it does turn out to be Twenty Nineteen I can make a trac ticket but just in case this is editor let's open here first.

@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention Needs Testing Needs further testing to be confirmed. labels Feb 6, 2020
@karmatosed
Copy link
Member Author

This trac ticket might be related and if so good to get fixed for 5.4: https://core.trac.wordpress.org/ticket/48526

@jasmussen
Copy link
Contributor

Great detective work.

The misalignment issue you report is almost certainly the one that I have provide a patch for in the trac ticket. We really need that shipped for TwentyNineteen, as the refactor of the editor that makes the misalignment happen will ship with 5.4.

There's a separate misalignment issue with the default appender that needs fixing in the block editor, note the margin on the left here:

Screenshot 2020-02-06 at 16 18 08

And then note once I've started typing:

Screenshot 2020-02-06 at 16 18 20

Note that the font discrepancy is separete from that, and is a TwentyTwenty specific issue, that is in part tracked in #18571.

@kjellr
Copy link
Contributor

kjellr commented Feb 6, 2020

Just a heads up that I've updated core.trac.wordpress.org/ticket/48526, and it should definitely take care of this. It needs some testing and a couple more small fixes before landing.

@jorgefilipecosta
Copy link
Member

Closing this ticket as https://core.trac.wordpress.org/ticket/48526 seems to address the issue. Thank you to all involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants