Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeControl: Missing disabled style and behaviour. #20319

Closed
pento opened this issue Feb 19, 2020 · 1 comment · Fixed by #20723
Closed

RangeControl: Missing disabled style and behaviour. #20319

pento opened this issue Feb 19, 2020 · 1 comment · Fixed by #20723
Assignees
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@pento
Copy link
Member

pento commented Feb 19, 2020

Describe the bug

After the changes in #19916, setting the disabled prop on a RangeControl component no longer makes it appear disabled.

Additionally, the disabled prop is not being passed to the InputNumber, so the value of the RangeControl can still be changed, despite being disabled.

I also noticed that the disabled prop isn't shown in the RangeControl storybook.

To reproduce

Steps to reproduce the behaviour:

  1. Create an instance of RangeControl, with the disabled prop set to true.
  2. Observe that the styling of the slider appears the same.
  3. Change the value in the number input, see that the slider changes.

Expected behavior

That the value of the RangeControl doesn't change when it's disabled, and it has a visual appearance of being disabled.

@pento pento added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Package] Components /packages/components labels Feb 19, 2020
@pento
Copy link
Member Author

pento commented Feb 19, 2020

@ItsJonQ: Pinging you on this, since you appear to be doing some work on RangeControl. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants