Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Preview of Templates and template Parts #20478

Closed
mtias opened this issue Feb 26, 2020 · 10 comments · Fixed by #20958
Closed

Show Preview of Templates and template Parts #20478

mtias opened this issue Feb 26, 2020 · 10 comments · Fixed by #20958
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Feb 26, 2020

It'd be interesting to render a preview when hovering templates or template parts for context before switching.

image

It might get tricky to load them dynamically, but it's worth exploring how it might work. (It might actually function as a preload for switching templates.)

@shaunandrews
Copy link
Contributor

Template Menu with Preview

@johnstonphilip
Copy link
Contributor

I love this, image previews are definitely much needed. Though I wonder if using hover as an action is generally a bad idea for accessibility, and also for mobile. Would these previews be available in any non-hover-based context?

@shaunandrews
Copy link
Contributor

Would these previews be available in any non-hover-based context?

Its not shown in my (quick) mockup, but I'd imagine if you used the keyboard to navigate the items in the list that we could show the preview. So both :hover and :focus could trigger the preview.

@johnstonphilip
Copy link
Contributor

Good point!

I am curious, is the general consensus about, say, a person with inaccurate/shaky hands that they should use the keyboard instead of the mouse? Or is it a goal to make moused-things as-easy-as-possible so they can use a mouse if they want to?

For :focus, This also wouldn't be available on mobile, is that right?

@johnstonphilip
Copy link
Contributor

P.S. I think that area for This template will be used by default for all of the pages on your site is awesome. Anything like that to help reduce the overhead of learning about template hierarchy is probably going to be really important, I think.

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Mar 6, 2020
@karmatosed
Copy link
Member

I think as a v1 the hover and show @shaunandrews you added works for me. There could be some placing negotiation of that hover, but it feels like worth getting into code.

@shaunandrews
Copy link
Contributor

I was originally trying to associate the preview with the item in the list by adjusting the vertical position. In reality, I think this is probably a bad idea; I think it could make it difficult to quickly scrub through the list and compare the previews.

Instead, lets keep the position of the preview fixed as you hover items in the list:

Template Menu with Preview i2

@dwolfe
Copy link

dwolfe commented Mar 6, 2020

To offer a contrasting opinion, I think the preview and the description are relevant and useful, but I wonder if showing it while hovering over items in a dropdown is the best place for it. What do you think about not showing previews here, but adding a "View all templates" link to the dropdown, and moving the thumbnail and description to a page where we have more space and control? (NOTE: We're already moving towards having a home for templates in #20477)

@shaunandrews
Copy link
Contributor

What do you think about not showing previews here, but adding a "View all templates" link to the dropdown, and moving the thumbnail and description to a page where we have more space and control?

I explored something just like that this morning:

All Templates View

@mtias
Copy link
Member Author

mtias commented Mar 7, 2020

I like this last one. The previews on hover / focus is still a separate thing for quick selection. We already have it for the block inserter so there's nothing novel in this paradigm, just more consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants