-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Preview of Templates and template Parts #20478
Comments
I love this, image previews are definitely much needed. Though I wonder if using |
Its not shown in my (quick) mockup, but I'd imagine if you used the keyboard to navigate the items in the list that we could show the preview. So both |
Good point! I am curious, is the general consensus about, say, a person with inaccurate/shaky hands that they should use the keyboard instead of the mouse? Or is it a goal to make moused-things as-easy-as-possible so they can use a mouse if they want to? For |
P.S. I think that area for |
I think as a v1 the hover and show @shaunandrews you added works for me. There could be some placing negotiation of that hover, but it feels like worth getting into code. |
I was originally trying to associate the preview with the item in the list by adjusting the vertical position. In reality, I think this is probably a bad idea; I think it could make it difficult to quickly scrub through the list and compare the previews. Instead, lets keep the position of the preview fixed as you hover items in the list: |
To offer a contrasting opinion, I think the preview and the description are relevant and useful, but I wonder if showing it while hovering over items in a dropdown is the best place for it. What do you think about not showing previews here, but adding a "View all templates" link to the dropdown, and moving the thumbnail and description to a page where we have more space and control? (NOTE: We're already moving towards having a home for templates in #20477) |
I like this last one. The previews on hover / focus is still a separate thing for quick selection. We already have it for the block inserter so there's nothing novel in this paradigm, just more consistency. |
It'd be interesting to render a preview when hovering templates or template parts for context before switching.
It might get tricky to load them dynamically, but it's worth exploring how it might work. (It might actually function as a preload for switching templates.)
The text was updated successfully, but these errors were encountered: