Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block API: Extract common logic as an initial screen for blocks that define variations #20582

Open
gziolo opened this issue Mar 2, 2020 · 0 comments
Open

Block API: Extract common logic as an initial screen for blocks that define variations #20582

gziolo opened this issue Mar 2, 2020 · 0 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Extensibility The ability to extend blocks or the editing experience Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@gziolo
Copy link
Member

gziolo commented Mar 2, 2020 •
edited
Loading

Description

Follow-up for #16283.

In #18283, the Columns was refactored to use block variations API integrated into block variations picker.

We should take it to the next level and extract common logic as an initial screen for blocks that define variations so it's automated. The biggest challenge is how to detect whether a variation was already applied to the block. The issues pop up when you load again the content saved in the database.

Some ideas to explore were shared by @kjellr in #16283 (comment):

This isn't necessarily limited to layout though — theoretically, blocks could use this to allow users to choose any sort of default state for their block. A couple possible ideas:

Example - Map Example - Form
@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Feature] Block API API that allows to express the block paradigm. [Feature] Extensibility The ability to extend blocks or the editing experience labels Mar 2, 2020
@gziolo gziolo mentioned this issue Mar 2, 2020
Closed
16 tasks
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Mar 2, 2020
@gziolo gziolo mentioned this issue Jul 2, 2020
Closed
@gziolo gziolo mentioned this issue Oct 23, 2020
Merged
6 tasks
@gziolo gziolo added [Feature] Blocks Overall functionality of blocks and removed [Feature] Block API API that allows to express the block paradigm. labels Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Extensibility The ability to extend blocks or the editing experience Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gziolo