Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich Text: Selection placed incorrectly after deleting empty paragraph (Internet Explorer) #20598

Closed
aduth opened this issue Mar 2, 2020 · 2 comments · Fixed by #21092
Closed

Rich Text: Selection placed incorrectly after deleting empty paragraph (Internet Explorer) #20598

aduth opened this issue Mar 2, 2020 · 2 comments · Fixed by #21092
Assignees
@ellatrix
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Package] Rich text /packages/rich-text [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@aduth
Copy link
Member

aduth commented Mar 2, 2020 •
edited
Loading

Previously: #20594 (comment)
Possibly related to: #19536

Steps to Reproduce:

  1. (Prerequisite) Use Internet Explorer
  2. Navigate to Posts > Add New
  3. Insert a paragraph with some text
  4. Press Enter to insert a second paragraph
  5. Press Backspace to delete the second paragraph
  6. Note that the caret selection is placed at the beginning of the first paragraph

Expected Outcome:

Caret selection should be placed at the end of the first paragraph.

Additional Context:

This is working correctly in WordPress 5.3.2 and, as such, is flagged as "Regression".

cc @ellatrix
@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Browser Issues Issues or PRs that are related to browser specific problems [Type] Regression Related to a regression in the latest release [Package] Rich text /packages/rich-text labels Mar 2, 2020
This was referenced Mar 2, 2020
Merged
Closed
@aduth aduth added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Mar 2, 2020
@ellatrix
Copy link
Member

The problem is this line that has been added: https://github.com/WordPress/gutenberg/pull/20594/files#diff-829f9f4e942450ee8c33f082c016b173R322.

@ellatrix
Copy link
Member

If I comment that line out, everything works fine.

@ellatrix ellatrix mentioned this issue Mar 23, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 23, 2020
@aduth aduth mentioned this issue Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Package] Rich text /packages/rich-text [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IE11: fix focus on backspace WordPress/gutenberg
2 participants
@aduth @ellatrix