-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color options for Social Icons block #21605
Comments
Drafted #21639 to make this happen. It's thankfully not that hard to change both the foreground and background color. In that draft PR I try to be "smart" by inheriting colors, which works fine as a proof of concept, but doesn't work in practice. But it can easily be commandeered to add completely custom color support. |
One concern here is these companies typically have logo usage guidelines that limit the colors you can use. Often at most it's the official logo color(s), black and white. We'd probably want to confirm that first, then limit the color options. |
@earnjam we actually got some decent analysis of that here: #21900 (comment) |
Just came here to +1 on the idea. It's been a bit hard to use the block on some opinionated background colours. |
@shaunandrews yes, that's what I had in mind |
It'd be nice to add a color option to the social icons block (the wrapper) so you could make all the icons be a specific color: all black, all white, custom color. If it gets tricky to allow any color given how the svgs might be constructed, perhaps just a setting for black / white could work.
The text was updated successfully, but these errors were encountered: