Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color options for Social Icons block #21605

Closed
mtias opened this issue Apr 15, 2020 · 7 comments · Fixed by #28084
Closed

Color options for Social Icons block #21605

mtias opened this issue Apr 15, 2020 · 7 comments · Fixed by #28084
Assignees
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Apr 15, 2020

It'd be nice to add a color option to the social icons block (the wrapper) so you could make all the icons be a specific color: all black, all white, custom color. If it gets tricky to allow any color given how the svgs might be constructed, perhaps just a setting for black / white could work.

@mtias mtias added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Apr 15, 2020
@jasmussen
Copy link
Contributor

Drafted #21639 to make this happen. It's thankfully not that hard to change both the foreground and background color. In that draft PR I try to be "smart" by inheriting colors, which works fine as a proof of concept, but doesn't work in practice. But it can easily be commandeered to add completely custom color support.

@earnjam
Copy link
Contributor

earnjam commented May 15, 2020

One concern here is these companies typically have logo usage guidelines that limit the colors you can use. Often at most it's the official logo color(s), black and white. We'd probably want to confirm that first, then limit the color options.

@jasmussen
Copy link
Contributor

@earnjam we actually got some decent analysis of that here: #21900 (comment)

@iamtakashi
Copy link

iamtakashi commented May 22, 2020

Just came here to +1 on the idea. It's been a bit hard to use the block on some opinionated background colours.

@alaczek
Copy link

alaczek commented Jun 19, 2020

Being able to pick a uniform custom color for the icons will come in really handy in the header/footer design where we often want them to blend in with the overall design.

A few visual examples:
image

image

image

@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Jun 19, 2020
@shaunandrews
Copy link
Contributor

I think we could probably use the normal color control to override the automatic colors; Clearing the chosen color would return to using the brand-colors:

social-icons-color

@mtias
Copy link
Member Author

mtias commented Sep 25, 2020

@shaunandrews yes, that's what I had in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants