Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: Drag & Drop #22297

Closed
paaljoachim opened this issue May 12, 2020 · 7 comments · Fixed by #23952
Closed

List View: Drag & Drop #22297

paaljoachim opened this issue May 12, 2020 · 7 comments · Fixed by #23952
Assignees
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented May 12, 2020

Add Drag & Drop to the Navigation Navigator and the Block Navigation.

The Block Navigation movers have just been merged:
#22287

An issue has also been made to add movers to the top bar Block Navigator panel.
#22287

The merged PR the movers look like this.

In the Navigation Block toolbar open the Navigator.
Open-block-Navigator-toolbar

A modul screen is seen.
Modul-Block-Navigator-Nav

The sidebar settings also contain a Navigator.
Block-Navigator-sidebar-Nav

I will also suggest adding in a grid icon. To give a visual hint that one can drag & drop the while section. Or just remove the grid icon and be able to drag & drop the while up and down arrow section.
Modul-Block-navigator-drag-drop-grid-icon

At present G2 does not have any visual hint. As one only drags the up and down arrow area.
Screen Shot 2020-05-12 at 17 34 08

@paaljoachim paaljoachim changed the title Block Navigator/Navigation: Drag & Drop Block Navigator: Drag & Drop May 12, 2020
@paaljoachim paaljoachim changed the title Block Navigator: Drag & Drop Block Navigator/Navigation: Drag & Drop May 12, 2020
@annezazu annezazu added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Feature] Drag and Drop Drag and drop functionality when working with blocks labels May 12, 2020
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label May 12, 2020
@karmatosed
Copy link
Member

I do think having this drag and drop is sensible, what I do wonder is the iconography and how to ensure this doesn't have yet another interface for that. @jasmussen just going to loop you in for some direction from the iterative work on interface, what do you think would be a good icon for this? Does it even need an icon if that action happens based on arrows?

Another concern to raise here, is that the ellipsis is being added to that interface, so any mockups should also include that to balance.

@karmatosed karmatosed added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels May 13, 2020
@jasmussen
Copy link
Contributor

I do agree that drag and drop would be really nice in this interface.

But I think that it needs to be the same drag and drop we end up with for blocks themselves, both visually and technically, and since those deserve a steady hand and a serious revisit, I would suggest this issue is blocked by drag and drop being improved for blocks themselves.

@karmatosed
Copy link
Member

Thanks for the insights @jasmussen. I am firmly on the side that I really want this unified as it's the type of interaction would be unexpected if different in places.

@paaljoachim
Copy link
Contributor Author

@karmatosed
I found the issue you were mentioning in regards to the ellipsis:
#22089

@jasmussen
I agree this issue is blocked until G2 Drag & drop movers have been worked through, so that we can implement the same in the Block Navigator and Block Navigation. We then need the Blocked label for this issue.

The Block Movers issues:
Evolving Movers: #21935

@paaljoachim
Copy link
Contributor Author

paaljoachim commented May 16, 2020

The easiest form of drag & drop would be hovering over a menu item, cursor turns into a hand with a finger pointing and one drags the menu item to the new location in the nav structure.
Nav-structure-drag

@talldan talldan self-assigned this May 27, 2020
@talldan talldan added the [Status] In Progress Tracking issues with work in progress label May 27, 2020
@manmotive
Copy link

I realise this is complex already, but can I request it be considered to add shift-clicking to select multiple blocks (within the same level), to allow multiple items to be dragged at once. This is something that would make this screen an improvement over the current nav-menus.php screen.

@SchneiderSam
Copy link

I just test #18014 and its so useful. Please give us the movers also in the "normal" editor! I use the Navigator so much and the movers will help a lot!

@talldan talldan linked a pull request Aug 13, 2020 that will close this issue
@enriquesanchez enriquesanchez removed the Needs Design Needs design efforts. label Aug 14, 2020
@talldan talldan changed the title Block Navigator/Navigation: Drag & Drop List View: Drag & Drop Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants